Ticket #5717 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

SCAYT options must be the first in the context menu

Reported by: fredck Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4.1
Component: UI : Spell Checker Version: SVN (CKEditor) - OLD
Keywords: HasPatch Cc: SpellChecker.net, comp615@…

Description

The SCAYT suggestions and all SCAYT relative options must be the first in the context menu. This is the common behavior on applications, like MS Word and Firefox.

Attachments

5717.patch (1.2 KB) - added by comp615 4 years ago.
Patch as described in #3, config option removed and SCAYT moved to top

Change History

comment:1 Changed 4 years ago by garry.yao

  • Keywords Pending added; Confirmed removed
  • Milestone CKEditor 3.4 deleted

Hts a NOT SURE on this, cloning the desktop behavior here maybe inappropriate because native context menu could penetrate the app window while we have limited space for it, this will be important especially when editor is integrate into a small frame in host page.

comment:2 Changed 4 years ago by fredck

  • Keywords Confirmed added; Pending removed
  • Milestone set to CKEditor 3.4

This one has nothing to do with the size of the context menu, just with the order of items. Currently it's chaotic and not predictable.

comment:3 Changed 4 years ago by fredck

  • Milestone changed from CKEditor 3.4 to CKEditor 3.5

comment:4 Changed 4 years ago by comp615

  • Cc comp615@… added

There's already a config option for this: editor.config.scayt_contextMenuOntop

Solutions: 1) Do nothing 2) Change the setting to true by default 3) Remove the config and always make it on top

comment:5 Changed 4 years ago by fredck

KISS: I would vote 3.

We can rethink it if people start complaining.

Changed 4 years ago by comp615

Patch as described in #3, config option removed and SCAYT moved to top

comment:6 Changed 4 years ago by comp615

  • Keywords HasPatch added

comment:7 Changed 4 years ago by Saare

  • Status changed from confirmed to review
  • Owner set to Saare

comment:8 Changed 4 years ago by SpellChecker.net

The patch has been successfully tested by SpellChecker.net team.

comment:9 Changed 4 years ago by tobiasz.cudnik

  • Status changed from review to review_passed

comment:10 Changed 4 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [5834].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy