FF: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIDOMNSHTMLDocument.designMode]

[Wiktor Walc]

This is a regression bug introduced in CKEditor 3.3. It occurs when doing some specific DOM operations on the node that contains the editor. We had a similar problem in #5660.

Please check the attached files (unpack them in the _samples directory) to reproduce this issue. Works fine in CKEditor 3.2.1, 3.0 and all previous releases.

[Garry Yao]

The DOM operations could be reduced to only CSS 'display' change, we need to understand that there's no way for us to know such change is happened in the parent tree, so programming in a defensive style helps.

[Alfonso Martínez de Lizarrondo]

I have two questions/doubts with the patch:

The first function adds a

editor.document.getBody().focus(); 

at the end. Is it really needed? Other tickets have tried to avoid changing the focus as long as it's possible, so in order to have those issues back it would be better to know if it's needed and the drawbacks.

The second function finish with a call to blinkCursor() again. I think that the idea is that: function 1 fails, then function 2 is executed and then calling function 1 will work. Do we know that it's true and it won't start an endless loop of function 1 failing and executing function 2 over and over again?

[Garry Yao]

Review of quality, the focus body is necessary to avoid having a dumb cursor when clicking on non-body area, for safety, I've included a anti dead-loop check.

[Alfonso Martínez de Lizarrondo]

I didn't realize that it's replacing a call to doc.getBody().focus(), and the other place where it's being called seems to work correctly.

Anyway, the patch creates a new problem: load the test case or just replacebyclass, and without clicking or focusing the content, just press the Source button. It generates this error:

editor.document is null
http://localhost/ckeditor/_source/plugins/wysiwygarea/plugin.js
Line 832

[Garry Yao]

That's a careful catch while pretty an edge case though.

[Garry Yao]

Fixed with [5566].