Opened 6 years ago

Closed 6 years ago

#6043 closed Bug (fixed)

BIDI: When we apply RTL direction to a right aligned Paragraph, Paragraph is not moved to left & Alignment of Paragraph is not changed

Reported by: satya Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version: 3.3
Keywords: IBM Cc: damo, joek, jamcunni@…

Description

To reproduce the defect:

  1. Open Ajax sample.
  1. Type some text, keep the cursor in the paragraph and click on Align Right icon in the Tool bar.
  1. See that paragraph is moved to right and Align Right icon is selected in the Tool bar.
  1. keep the cursor in the Paragraph and click on RTL icon in the Tool bar.

Expected Result:

See that paragraph is moved to left and Align Left icon is selected in the Tool bar.

Actual Result:

Paragraph is staying on the right instead of moving to left & Alignment of Paragraph is also not changed & it is still shown as Right Aligned.

Attachments (2)

6043.patch (1.5 KB) - added by tobiasz.cudnik 6 years ago.
6043_2.patch (1.5 KB) - added by tobiasz.cudnik 6 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 6 years ago by fredck

  • Keywords Discussion added

I'm quite unsure about this one. The fact is that alignment is a "formatting" feature, while BiDi is a "semantics" feature.

If the user "formatted" the text to be at right, much probably s/he just wants it at right, no matter the language direction.

Opening a discussion around it.

comment:2 Changed 6 years ago by garry.yao

Hold the same opinion with Fred also, alignment has nothing to do with direction.

comment:3 Changed 6 years ago by damo

I would not say that alignment has nothing to do with direction. There is a reason why the default rendering in browsers in the following example is right aligned :

  <p dir="rtl">Test</p>

The moment that a user decides that something needs to be RTL, the default expectation is that the content will become right aligned. Agreed, alignment can always be overridden by the user, after they have set the direction.

comment:4 Changed 6 years ago by james c

  • Cc jamcunni@… added

comment:5 Changed 6 years ago by tobiasz.cudnik

  • Keywords Discussion removed
  • Owner set to tobiasz.cudnik
  • Status changed from new to assigned

I don't see a difference between mirroring margins and mirroring alignment when changing the direction.

I think we should have this missing feature in 3.4.2.

Changed 6 years ago by tobiasz.cudnik

comment:6 Changed 6 years ago by tobiasz.cudnik

  • Status changed from assigned to review

comment:7 Changed 6 years ago by tobiasz.cudnik

  • Status changed from review to review_failed

Changed 6 years ago by tobiasz.cudnik

comment:8 Changed 6 years ago by tobiasz.cudnik

  • Status changed from review_failed to review

comment:9 Changed 6 years ago by tobiasz.cudnik

  • Milestone set to CKEditor 3.4.2

comment:10 Changed 6 years ago by Saare

  • Status changed from review to review_passed

comment:11 Changed 6 years ago by garry.yao

'config.justifyClasses' is not working under the patch, while it should handled separately at #6510.

comment:12 Changed 6 years ago by tobiasz.cudnik

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5997].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy