#6510 closed Bug (fixed)
Margin mirroring doesn't respect style configuration
| Reported by: | Garry Yao | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.3 |
| Component: | Core : Styles | Version: | 3.4 |
| Keywords: | Cc: |
Description
Currently the 'indent' and 'justify' plugin that on behavior of 'dirChange' event doesn't consider class-based styling configuration e.g. 'justifyClasses' and 'indentClasses'.
Attachments (2)
Change History (12)
comment:1 Changed 14 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 14 years ago by
| Owner: | set to Tobiasz Cudnik |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 14 years ago by
| Milestone: | CKEditor 3.5 → CKeditor 3.4.3 |
|---|
comment:4 Changed 14 years ago by
| Status: | assigned → review |
|---|
Changed 14 years ago by
| Attachment: | 6510.patch added |
|---|
comment:5 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Ok, I believe that it's enough to append the original class name a "_RTL"? Unfortunately there's no RTL CSS selector ;)
Changed 14 years ago by
| Attachment: | 6510_2.patch added |
|---|
comment:6 Changed 14 years ago by
| Status: | review_failed → review |
|---|
Second patch uses "_rtl" prefix for indentClasses. Additionally, dirChange event now send an explicit information about new direction.
comment:7 Changed 14 years ago by
| Status: | review → review_passed |
|---|
Ok, looks good, be sure to append the following to _samples\assets\output_xhtml.css
.Indent1_rtl
{
margin-right: 40px;
}
.Indent2_rtl
{
margin-right: 80px;
}
.Indent3_rtl
{
margin-right: 120px;
}
comment:8 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6068], including output_xhtml.css changes.
Note: See
TracTickets for help on using
tickets.
We can't mirror indentClasses, as they are linear. What we can do about them is to introduce a dedicated setting to the config named eg indentClassesRtl. Then it would be possible.