Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6087 closed Bug (fixed)

IE: Caret doesn't blink on RTL dialogs

Reported by: fredck Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.4.2
Component: UI : Dialogs Version: 3.0
Keywords: IE Opera IBM Cc: satya

Description

In IE, the caret is not visible inside dialogs when the UI is RTL.

This is a followup ticket for comment:19:ticket:4615.

Attachments (5)

6087.patch (2.2 KB) - added by tobiasz.cudnik 6 years ago.
6087_2.patch (2.3 KB) - added by tobiasz.cudnik 6 years ago.
6087_3.patch (3.5 KB) - added by garry.yao 6 years ago.
6087.PNG (14.9 KB) - added by Saare 6 years ago.
6087_4.patch (4.4 KB) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (33)

comment:1 Changed 6 years ago by fredck

  • Status changed from new to confirmed

I'm constantly able to reproduce it with IE8 (Win7 64).

Saar instead doesn't see any problem with the Hebrew IE8 and IE7 (XP and Vista 32).

comment:2 Changed 6 years ago by Saare

It works fine for me with IE6 @ XP 32.

comment:3 Changed 6 years ago by fredck

  • Cc satya added
  • Keywords IBM added

#6176 has been marked as DUP.

comment:4 Changed 6 years ago by fredck

  • Milestone set to CKEditor 3.4.1

comment:5 Changed 6 years ago by tobiasz.cudnik

  • Owner set to tobiasz.cudnik
  • Status changed from confirmed to assigned

Changed 6 years ago by tobiasz.cudnik

comment:6 Changed 6 years ago by tobiasz.cudnik

  • Status changed from assigned to review

comment:7 Changed 6 years ago by Saare

  • Status changed from review to review_failed

I can live with the small extra padding at the right side but unfortunately this patch ruins the border at the left side for me.

Changed 6 years ago by tobiasz.cudnik

comment:8 Changed 6 years ago by tobiasz.cudnik

  • Status changed from review_failed to review

comment:9 Changed 6 years ago by Saare

Looks great at my side, let's also wait to Fred to see it really solved the problem.

comment:10 Changed 6 years ago by fredck

  • Status changed from review to review_failed

:/ this patch makes no difference for me. It would be wonderful to have someone else confirming the exact effect I'm having.

comment:11 Changed 6 years ago by garry.yao

Patch WFM in IE8 but not IE7.

comment:12 Changed 6 years ago by garry.yao

  • Keywords Opera added

Opera is affected also.

comment:13 Changed 6 years ago by garry.yao

  • Owner changed from tobiasz.cudnik to garry.yao
  • Status changed from review_failed to assigned

Changed 6 years ago by garry.yao

comment:14 Changed 6 years ago by garry.yao

  • Status changed from assigned to review
  • Version set to 3.0

comment:15 Changed 6 years ago by paho

In my case (Win7 64) patch works for FF, Opera, Chrome and IE8. For IE7 right border of some textboxes is missing.

comment:16 Changed 6 years ago by Saare

Looks ok on my env and IE8. Also need others to test the patch to see it's actually resolved for everybody.

comment:17 Changed 6 years ago by fredck

  • Status changed from review to review_passed

comment:18 Changed 6 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5975].

comment:19 Changed 6 years ago by james c

I believe that this fix may have introduced a new bug in IE7.

Select Arabic or Hebrew from the languages sample in IE7.
Click into the editor and click on the Insert Table icon.
See that the dialog appears BUT notice that the Summary & Caption text fields are missing a right hand edge.

Should a new ticket be raised to highlight this defect or should this ticket be reopened?

comment:20 Changed 6 years ago by Saare

  • Resolution fixed deleted
  • Status changed from closed to reopened

Confirmed with IE8 compat and IE7 mode, OK with standart and quirks.. \:
Reverted [5975] with [5998].

Changed 6 years ago by Saare

Changed 6 years ago by garry.yao

comment:21 Changed 6 years ago by garry.yao

  • Status changed from reopened to review

The new bug only happens on fields that has a relative 100% width in layout boxes, new patch gives layout boxes also a small padding to conquer that.

comment:22 Changed 6 years ago by Saare

  • Status changed from review to review_passed

comment:23 Changed 6 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5999].

comment:24 Changed 6 years ago by dinu

Reopen: Now the cursor disappears in LTR, in IE7, IE8 at right side.

comment:25 Changed 6 years ago by Saare

I'm not able to reproduce your problem @dinu.

comment:26 Changed 6 years ago by dinu

  • Open nightly build demo (any instance, English)
  • Click image button
  • In URL field type a very long string
  • Caret will disappear in the right side as the text is wider than the input
  • Same happens with nearly all dialog text input fields

comment:27 Changed 6 years ago by Saare

Ok I can see that now, it has nothing to do with that ticket though as I was able to reproduce the bug also on the demo. You can file a new ticket for that bug.

comment:28 Changed 6 years ago by dinu

Ok, I thought it was related because it involves the same caret-at-right position. I'll file a new bug then.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy