Opened 14 years ago
Closed 14 years ago
#6112 closed Bug (fixed)
BIDI: Alignment set to text in Table cell is not shown in the Tool bar when we press Enter to start a new Paragraph
Reported by: | Satya Minnekanti | Owned by: | Tobiasz Cudnik |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4.1 |
Component: | General | Version: | 3.4 Beta |
Keywords: | IBM | Cc: | Damian, joek |
Description
To reproduce the defect:
- Open Ajax sample.
- Insert a Table, go in to a Table cell, and click on an Alignment option(for eg: Align Right) in the Tool bar.
- Now Type the text in the cell and see that it is Right Aligned and Align Right icon in the Tool bar is highlighted.
- Press Enter.
Expected Result:
A New Paragraph starts and it should have Right Alignment as well and Align Right Icon in the Tool bar should be highlighted.
Actual Result:
A New Paragraph is started and it has Right Alignment but Align Right Icon in the Tool bar is not showing as highlighted and when we keep the cursor in the previous paragraph Align Right icon is not even highlighted for that Paragraph as well.
same behavior happens for all the Alignment options.
Attachments (2)
Change History (13)
comment:1 follow-ups: 2 3 Changed 14 years ago by
Keywords: | Pending added |
---|
comment:2 Changed 14 years ago by
Replying to tobiasz.cudnik:
I can't reproduce it, Alignment icon always represents correct state. Here's the content i've used:
<table> <tbody> <tr> <td style="text-align: right;"> <p> foo</p> <p> bar</p> </td> </tr> </tbody> </table>On what browser you're experiencing this issue ?
I could reproduce it on all the browsers FF3.5,IE6 & 7..even though <td style="text-align: right;"> is shown in HTML source for the Table cell, the corresponding icon(Align Right)is not shown as highlighted in the Tool bar when we keep the cursor in the paragraph.
comment:3 follow-up: 4 Changed 14 years ago by
Replying to tobiasz.cudnik:
I can't reproduce it, Alignment icon always represents correct state. Here's the content i've used:
<table> <tbody> <tr> <td style="text-align: right;"> <p> foo</p> <p> bar</p> </td> </tr> </tbody> </table>On what browser you're experiencing this issue ?
It might be useful to mention that this issue occurs when config.useComputedState = false;
comment:4 Changed 14 years ago by
Keywords: | Pending removed |
---|---|
Status: | new → confirmed |
Replying to satya:
It might be useful to mention that this issue occurs when config.useComputedState = false;
Yes, that changes everything.
comment:5 Changed 14 years ago by
Milestone: | → CKEditor 3.4.1 |
---|
comment:6 Changed 14 years ago by
Owner: | set to Tobiasz Cudnik |
---|---|
Status: | confirmed → assigned |
Changed 14 years ago by
Attachment: | 6112.patch added |
---|
comment:7 Changed 14 years ago by
Status: | assigned → review |
---|
comment:8 Changed 14 years ago by
Status: | review → review_failed |
---|
On L40 you should use getAttribute() and hot hasAttribute(). Also, please add || ''
after it to avoid having a null value.
Changed 14 years ago by
Attachment: | 6112_2.patch added |
---|
comment:9 Changed 14 years ago by
Status: | review_failed → review |
---|
comment:10 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:11 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [5856].
I can't reproduce it, Alignment icon always represents correct state. Here's the content i've used:
On what browser you're experiencing this issue ?