Opened 14 years ago

Closed 14 years ago

#6112 closed Bug (fixed)

BIDI: Alignment set to text in Table cell is not shown in the Tool bar when we press Enter to start a new Paragraph

Reported by: Satya Minnekanti Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4.1
Component: General Version: 3.4 Beta
Keywords: IBM Cc: Damian, joek

Description

To reproduce the defect:

  1. Open Ajax sample.
  1. Insert a Table, go in to a Table cell, and click on an Alignment option(for eg: Align Right) in the Tool bar.
  1. Now Type the text in the cell and see that it is Right Aligned and Align Right icon in the Tool bar is highlighted.
  1. Press Enter.

Expected Result:

A New Paragraph starts and it should have Right Alignment as well and Align Right Icon in the Tool bar should be highlighted.

Actual Result:

A New Paragraph is started and it has Right Alignment but Align Right Icon in the Tool bar is not showing as highlighted and when we keep the cursor in the previous paragraph Align Right icon is not even highlighted for that Paragraph as well.

same behavior happens for all the Alignment options.

Attachments (2)

6112.patch (964 bytes) - added by Tobiasz Cudnik 14 years ago.
6112_2.patch (970 bytes) - added by Tobiasz Cudnik 14 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 14 years ago by Tobiasz Cudnik

Keywords: Pending added

I can't reproduce it, Alignment icon always represents correct state. Here's the content i've used:

<table>
	<tbody>
		<tr>
			<td style="text-align: right;">
				<p>
					foo</p>
				<p>
					bar</p>
			</td>
		</tr>
	</tbody>
</table>

On what browser you're experiencing this issue ?

comment:2 in reply to:  1 Changed 14 years ago by Satya Minnekanti

Replying to tobiasz.cudnik:

I can't reproduce it, Alignment icon always represents correct state. Here's the content i've used:

<table>
	<tbody>
		<tr>
			<td style="text-align: right;">
				<p>
					foo</p>
				<p>
					bar</p>
			</td>
		</tr>
	</tbody>
</table>

On what browser you're experiencing this issue ?

I could reproduce it on all the browsers FF3.5,IE6 & 7..even though <td style="text-align: right;"> is shown in HTML source for the Table cell, the corresponding icon(Align Right)is not shown as highlighted in the Tool bar when we keep the cursor in the paragraph.

comment:3 in reply to:  1 ; Changed 14 years ago by Satya Minnekanti

Replying to tobiasz.cudnik:

I can't reproduce it, Alignment icon always represents correct state. Here's the content i've used:

<table>
	<tbody>
		<tr>
			<td style="text-align: right;">
				<p>
					foo</p>
				<p>
					bar</p>
			</td>
		</tr>
	</tbody>
</table>

On what browser you're experiencing this issue ?

It might be useful to mention that this issue occurs when config.useComputedState = false;

comment:4 in reply to:  3 Changed 14 years ago by Frederico Caldeira Knabben

Keywords: Pending removed
Status: newconfirmed

Replying to satya:

It might be useful to mention that this issue occurs when config.useComputedState = false;

Yes, that changes everything.

comment:5 Changed 14 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4.1

comment:6 Changed 14 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: confirmedassigned

Changed 14 years ago by Tobiasz Cudnik

Attachment: 6112.patch added

comment:7 Changed 14 years ago by Tobiasz Cudnik

Status: assignedreview

comment:8 Changed 14 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

On L40 you should use getAttribute() and hot hasAttribute(). Also, please add || '' after it to avoid having a null value.

Changed 14 years ago by Tobiasz Cudnik

Attachment: 6112_2.patch added

comment:9 Changed 14 years ago by Tobiasz Cudnik

Status: review_failedreview

comment:10 Changed 14 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:11 Changed 14 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [5856].

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy