Ticket #6117 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

BIDI: Language direction is changing when we come out of Numbered/Bulleted list

Reported by: satya Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4.1
Component: General Version: 3.4 Beta
Keywords: IBM Cc: damo,joek

Description

To reproduce the defect:

Scenario 1:

  1. Open Ajax sample.
  1. Type few lines of text, select all the lines & click on RTL icon in the Tool bar.
  1. See that the language direction of the lines are changed to Right and RTL Icon in the Tool bar is selected.
  1. Now select all the lines and click on Numbers/Bullets icon in the Tool bar.
  1. See that a Numbered/Bulleted list appears with RTL language direction.
  1. Now select all the list items and press Decrease Indent icon.

Expected Result:

Numbered/Bulleted list is removed but the Language direction of text in the lines should still be from Right to Left(RTL).

Actual Result:

Numbered/Bulleted list is removed but Language direction of text in in the lines is removed and they have no language direction set.

Scenario 2:

  1. Open Ajax sample.
  1. Type few lines of text, select all the lines & click on RTL icon in the Tool bar.
  1. See that the language direction of the lines are changed to Right and RTL Icon in the Tool bar is selected.
  1. Now select all the lines and click on Numbers/Bullets icon in the Tool bar.
  1. See that a Numbered/Bulleted list appears with RTL language direction.
  1. go to the last list item and press Enter Twice.

Expected Result:

See that you are out of Numbered/Bulleted but the direction of text in the New Paragraph should still be from Right to Left(RTL).

Actual Result:

we are out of Numbered/Bulleted list is removed but New Paragraph has no explicit Language direction set.

Attachments

6117.patch (747 bytes) - added by tobiasz.cudnik 4 years ago.
6117_2.patch (817 bytes) - added by tobiasz.cudnik 4 years ago.

Change History

comment:1 Changed 4 years ago by tobiasz.cudnik

  • Status changed from new to assigned
  • Owner set to tobiasz.cudnik
  • Milestone set to CKEditor 3.4.1

Changed 4 years ago by tobiasz.cudnik

comment:2 Changed 4 years ago by tobiasz.cudnik

  • Status changed from assigned to review

comment:3 Changed 4 years ago by fredck

The fix looks like correct, but I'm not able to test it due to #6138. We need to fix that one first.

comment:4 Changed 4 years ago by Saare

  • Status changed from review to review_failed

The direction CSS should also be considered.

Changed 4 years ago by tobiasz.cudnik

comment:5 Changed 4 years ago by tobiasz.cudnik

  • Status changed from review_failed to review

comment:6 Changed 4 years ago by Saare

  • Status changed from review to review_passed

comment:7 Changed 4 years ago by tobiasz.cudnik

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [5857].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy