Opened 14 years ago
Closed 14 years ago
#6225 closed Bug (fixed)
[FF] Can not transform sevaral lines to list with enterMode BR.
| Reported by: | Sa'ar Zac Elias | Owned by: | Paweł Horzela |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.2 |
| Component: | Core : Lists | Version: | 3.3 |
| Keywords: | Firefox | Cc: |
Description
Open a sample, with enterMode set to br.
Type a few lines of text and click on one of the list icons.
Notice that only the first line is transformed into a list item.
A regression from the 3.3.
Attachments (2)
Change History (14)
comment:1 Changed 14 years ago by
| Keywords: | Firefox added |
|---|
comment:2 Changed 14 years ago by
| Owner: | set to Paweł Horzela |
|---|---|
| Status: | new → assigned |
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
The issue was introduced in #5568 in CKEDITOR.dom.range.setEnd method.
comment:5 Changed 14 years ago by
| Status: | assigned → review |
|---|
comment:6 Changed 14 years ago by
comment:7 Changed 14 years ago by
Although after second thought, those tickets concerns different browsers, so we could also distinguish the logic for each one.
Changed 14 years ago by
| Attachment: | 6225_2.patch added |
|---|
comment:8 Changed 14 years ago by
| Status: | review → review_failed |
|---|
@paho The first part of fix is perfect, I'm adding the second little fix into the iterator now.
@Tobias Let's make the review independent of #6361, I didn't see much relevance.
comment:9 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:10 Changed 14 years ago by
| Status: | review → review_passed |
|---|
comment:12 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Note: See
TracTickets for help on using
tickets.
This issue was introduced in revision 5694: http://dev.ckeditor.com/changeset/5694