Ticket #6225 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

[FF] Can not transform sevaral lines to list with enterMode BR.

Reported by: Saare Owned by: paho
Priority: Normal Milestone: CKEditor 3.4.2
Component: Core : Lists Version: 3.3
Keywords: Firefox Cc:

Description

Open a sample, with enterMode set to br.
Type a few lines of text and click on one of the list icons.
Notice that only the first line is transformed into a list item.
A regression from the 3.3.

Attachments

6225.patch (591 bytes) - added by paho 4 years ago.
Patch
6225_2.patch (1.6 KB) - added by garry.yao 4 years ago.

Change History

comment:1 Changed 4 years ago by Saare

  • Keywords Firefox added

comment:2 Changed 4 years ago by paho

  • Owner set to paho
  • Status changed from new to assigned

comment:3 Changed 4 years ago by paho

This issue was introduced in revision 5694: http://dev.ckeditor.com/changeset/5694

comment:4 Changed 4 years ago by paho

The issue was introduced in #5568 in CKEDITOR.dom.range.setEnd method.

Changed 4 years ago by paho

Patch

comment:5 Changed 4 years ago by paho

  • Status changed from assigned to review

comment:6 Changed 4 years ago by tobiasz.cudnik

I'm not sure if this patch is correct because TC from #5568 which should prove this can't be executed because of regression #6361. I think we need to wait for #6361 to be fixed.

comment:7 Changed 4 years ago by tobiasz.cudnik

Although after second thought, those tickets concerns different browsers, so we could also distinguish the logic for each one.

Changed 4 years ago by garry.yao

comment:8 Changed 4 years ago by garry.yao

  • Status changed from review to review_failed

@paho The first part of fix is perfect, I'm adding the second little fix into the iterator now.

@Tobias Let's make the review independent of #6361, I didn't see much relevance.

comment:9 Changed 4 years ago by paho

  • Status changed from review_failed to review

comment:10 Changed 4 years ago by Saare

  • Status changed from review to review_passed

comment:11 Changed 4 years ago by paho

Fixed with [5936]

comment:12 Changed 4 years ago by paho

  • Status changed from review_passed to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy