Ticket #6395 (review_failed Bug)

Opened 4 years ago

Last modified 4 years ago

Unable to set formating on empty page

Reported by: krst Owned by: mani
Priority: Normal Milestone:
Component: Core : Styles Version: 3.4.1
Keywords: Opera Cc:

Description (last modified by mani) (diff)

Found when checking #6370 In Opera

  • set new empty page
  • set text formating as "Formated"
  • enter some text - formating is back to normal
  • set formating again - enetered text format changes itself (video)
  • result in CKE3.4.1

{{{{ <pre> test<span style="display: none">&nbsp;</span></pre> <pre> <span style="display: none">&nbsp;</span> </pre> }}} The same test case in CKE 3.4

<pre>
<span _fck_bookmark="1" style="display: none">&nbsp;</span>test</pre>
<pre>
<span _fck_bookmark="1" style="display: none">&nbsp;</span>
</pre>
}}}[[BR]]
[[BR]]
[[BR]]

Attachments

krst 15.56.15 .avi (137.0 KB) - added by krst 4 years ago.
6395.patch (668 bytes) - added by mani 4 years ago.
Patch

Change History

Changed 4 years ago by krst

comment:1 Changed 4 years ago by garry.yao

  • Milestone set to CKEditor 3.4.2

pre-formatted style is not opened properly, while other blocks are good, the cursor is not blinking after applying them.

comment:2 Changed 4 years ago by garry.yao

  • Status changed from new to confirmed

comment:3 Changed 4 years ago by garry.yao

Let's first get #6282 fixed.

comment:4 Changed 4 years ago by paho

  • Status changed from confirmed to assigned
  • Owner set to paho

comment:5 Changed 4 years ago by mani

  • Owner changed from paho to mani

Changed 4 years ago by mani

Patch

comment:6 Changed 4 years ago by mani

  • Status changed from assigned to review

comment:7 Changed 4 years ago by garry.yao

  • Status changed from review to review_failed

@mani Ah...hard to believe this is a fix...the 'newBlock' may have contents from existing blocks.

comment:8 Changed 4 years ago by garry.yao

I think you'll need to briefly explain a bit the cause behind such a fix.

comment:9 Changed 4 years ago by mani

  • Description modified (diff)

Look at the code:

//document.body.contentEditable = false
document.designMode = 'on';

var sel = window.getSelection();
sel.removeAllRanges();


It is not working but should but when we uncomment first line and comment second everythink works. Additionaly I can say when designMode == 'on', sel.AddRange() don`t work too so we can not modify selection.

Maybe this will be some tip to others.

comment:10 Changed 4 years ago by mani

Problem was send to Opera
DSK-317210@…

comment:11 Changed 4 years ago by garry.yao

  • Milestone CKEditor 3.4.2 deleted

I don't quite understand the bug you're pointing to, the test case you've reported to Opera could present here on ticket.

  1. We're not using "designMode" for Opera;
  2. If native range manipulation doesn't work, does it affects also other scenarios?

Anyway, as we're at the time of preparing the release of 3.4.2, deferring it.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy