Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#6461 closed Bug (fixed)

BIDI: Paragraph alignment lost when switching list to paragraph

Reported by: damo Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version:
Keywords: IBM Cc: joek, satya, james, c

Description

When a list is unset, the paragraph alignment for each list item is lost.

To reproduce:

  1. Create the following sample content:
      <p>Paragraph 1</p>
      <p style="text-align: center;">Paragraph 2</p>
      <p style="text-align: right;">Paragraph 3</p>
    
  1. Select the paragraphs and click list button to make a list

At this stage the markup is:

<ul>
	<li>Paragraph 1</li>
	<li style="text-align: center;">Paragraph 2</li>
	<li style="text-align: right;">Paragraph 3</li>
</ul>
  1. Select the list and click list button again to undo list

Result:

  <p>Paragraph 1</p>
  <p>Paragraph 2</p>
  <p>Paragraph 3</p>

Expected:

  <p>Paragraph 1</p>
  <p style="text-align: center;">Paragraph 2</p>
  <p style="text-align: right;">Paragraph 3</p>

Attachments (2)

6461.patch (589 bytes) - added by Saare 6 years ago.
6461_2.patch (1.4 KB) - added by Saare 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by Saare

  • Status changed from new to confirmed

Not much of a bidi thing though.

Changed 6 years ago by Saare

comment:2 Changed 6 years ago by Saare

  • Milestone set to CKEditor 3.4.2
  • Owner set to Saare
  • Status changed from confirmed to review

comment:3 Changed 6 years ago by garry.yao

  • Status changed from review to review_failed

The change must happen around L115 instead of the position in the patch, otherwise it will breaks enterMode = BR.

Changed 6 years ago by Saare

comment:4 Changed 6 years ago by Saare

  • Status changed from review_failed to review

comment:5 Changed 6 years ago by garry.yao

  • Status changed from review to review_passed

comment:6 Changed 6 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5941].

comment:7 Changed 5 years ago by fredck

  • Cc james c added; james c removed
Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy