Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6467 closed Bug (fixed)

setState(CKEDITOR.TRISTATE_DISABLED) on 'mode' impossible for maximize plugin

Reported by: tony Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4.2
Component: UI : Toolbar Version: 3.4.1
Keywords: Cc:

Description

editor.on( 'mode', function() {
	if ( editor.mode == 'source' ) {
		editor.getCommand('maximize').setState(CKEDITOR.TRISTATE_DISABLED);
	}
});

Doesn't work as expected (I guess due to setState gymnastics going on in plugins/maximize/plugin.js) So this appears to make it impossible to disable the maximise plugin when switching to source view. It also reveals an inconsistency in CKEditor's API.

The above method works fine for 'newpage', 'preview', 'selectAll' but not maximize.

Attachments (1)

6467.patch (757 bytes) - added by Saare 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by Saare

  • Status changed from new to confirmed

Changed 6 years ago by Saare

comment:2 Changed 6 years ago by Saare

  • Component changed from General to UI : Toolbar
  • Milestone set to CKEditor 3.4.2
  • Owner set to Saare
  • Status changed from confirmed to review

comment:3 Changed 6 years ago by garry.yao

  • Status changed from review to review_passed

comment:4 Changed 6 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5940].

comment:5 Changed 6 years ago by tony

Wow guys! Nice job.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy