Opened 6 years ago

Closed 5 years ago

#6491 closed Bug (fixed)

The image lock ratio is set when the image URL field is populated.

Reported by: JoeK Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.3
Component: UI : Dialogs Version: 3.0
Keywords: IBM Cc: damo

Description

  1. Open the image dialog.
  1. Click on the lock ratio icon to unlock it.
  1. Enter an image URL in the URL field.
  1. Press tab to remove focus from the URL field.

Observe that the lock ratio is automatically reset. You have to click it again to unlock the ratio before continuing.

The button should not be reset to 'locked' if the user explicitly set it to unlock. This behaviour could be confusing to a blind user. I am not sure why the URL field has an affect on the lock ratio button? I'm sure there was a valid reason.

Attachments (2)

6491.patch (699 bytes) - added by garry.yao 5 years ago.
6491_2.patch (2.1 KB) - added by garry.yao 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by garry.yao

comment:1 Changed 5 years ago by garry.yao

  • Keywords HasPatch added
  • Status changed from new to confirmed

comment:2 Changed 5 years ago by Saare

  • Version changed from 3.5 (SVN - 3.5.x) to 3.0

comment:3 Changed 5 years ago by garry.yao

  • Keywords HasPatch removed
  • Owner set to garry.yao
  • Status changed from confirmed to review

comment:4 Changed 5 years ago by wwalc

  • Milestone set to CKEditor 3.5.3

comment:5 Changed 5 years ago by Saare

  • Status changed from review to review_passed

Changed 5 years ago by garry.yao

comment:6 Changed 5 years ago by garry.yao

  • Status changed from review_passed to review

I've found the previous patch problematic as it doesn't restore lock ratio between dialog openings.

comment:7 Changed 5 years ago by fredck

  • Status changed from review to review_passed

comment:8 Changed 5 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6565].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy