Opened 6 years ago

Closed 6 years ago

#6568 closed Bug (fixed)

Bug in table insert row

Reported by: z134 Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: Core : Tables Version: 3.0
Keywords: IBM Cc: satya_minnekanti@…

Description

Hello!

I've found the bug in release 3.4.1 and in earlier reliases: any attempt to add a row to a table with a cell, splitted horizontally, ruins the table completely. This is a simple example. Create table:

<table border="1" cellpadding="1" cellspacing="1" style="width: 500px">

<tbody>

<tr>

<td rowspan="2">

&nbsp;</td>

<td>

&nbsp;</td>

</tr> <tr>

<td>

&nbsp;</td>

</tr>

</tbody>

</table>

The table has one row and two columns. The right cell is divided horizontally. If you try to add row to the table (before or after existing row - does not matter) - the table corrupts.

That is the story :(

Attachments (3)

6568.patch (4.4 KB) - added by garry.yao 6 years ago.
6568_2.patch (11.6 KB) - added by garry.yao 6 years ago.
6568_3.patch (12.2 KB) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 6 years ago by garry.yao

  • Keywords table insert split removed
  • Milestone set to CKEditor 3.4.3
  • Status changed from new to confirmed
  • Version changed from 3.4.1 to 3.0

Changed 6 years ago by garry.yao

comment:2 Changed 6 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from confirmed to review

Revised 'insertRow' and 'insertCol' to handle cell spanning.

comment:3 Changed 6 years ago by fredck

  • Milestone changed from CKEditor 3.4.3 to CKEditor 3.5.1

comment:4 Changed 6 years ago by garry.yao

  • Summary changed from Bug in table insert line to Bug in table insert row

comment:5 Changed 6 years ago by garry.yao

  • Status changed from review to review_failed

delete row/column should be included also, v2 ticket #2813.

Changed 6 years ago by garry.yao

comment:6 Changed 6 years ago by garry.yao

  • Status changed from review_failed to review

A completely rewrite of the insert/delete column/row functions that takes care of cell spanning.

comment:7 Changed 6 years ago by tobiasz.cudnik

  • Status changed from review to review_passed

comment:8 Changed 6 years ago by garry.yao

  • Status changed from review_passed to review_failed

"insert column after" with the following content and cursor position produces wrong result:

<table border="1" cellpadding="1" cellspacing="1" style="width: 500px;">
	<tbody>
		<tr>
			<td colspan="2" rowspan="1">
				1</td>
			<td colspan="1" rowspan="2">
				2^</td>
		</tr>
		<tr>
			<td>
				3</td>
			<td>
				4</td>
		</tr>
		<tr>
			<td>
				5</td>
			<td>
				6</td>
			<td>
				7</td>
		</tr>
	</tbody>
</table>

comment:9 Changed 6 years ago by wwalc

  • Component changed from General to Core : Tables

comment:10 Changed 6 years ago by satya

  • Cc satya_minnekanti@… added
  • Keywords IBM added

Changed 6 years ago by garry.yao

comment:11 Changed 6 years ago by garry.yao

  • Status changed from review_failed to review

comment:12 Changed 6 years ago by Saare

  • Status changed from review to review_passed

comment:13 Changed 6 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6328].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy