Ticket #6644 (closed Task: fixed)

Opened 3 years ago

Last modified 3 years ago

Restrict onmousedown listener to the toolbar

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: CKEditor 3.4.3
Component: UI : Toolbar Version:
Keywords: Cc:

Description

Follow up from #6416

Currently the whole editor wrapper has an onmousedown = return false, and it seems that the aim is to avoid problems with the toolbar.

So the proper solution seems to move the listener just to the toolbar and remove the "strange" code in the sourcearea plugin.

Attachments

6644.patch​ (2.0 KB) - added by alfonsoml 3 years ago.
Proposed patch

Change History

Changed 3 years ago by alfonsoml

Proposed patch

comment:1 Changed 3 years ago by alfonsoml

  • Status changed from new to review

We must check that there's nothing else broken by this change.

comment:2 Changed 3 years ago by garry.yao

  • Status changed from review to review_passed
  • Type changed from Bug to Task
  • Component changed from General to UI : Toolbar
  • Milestone set to CKEditor 3.4.3

comment:3 Changed 3 years ago by alfonsoml

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6057]

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy