Opened 6 years ago

Closed 6 years ago

#6909 closed Bug (fixed)

GIF icons of external plugins are not diplayed in toolbar

Reported by: andrazk Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: UI : Toolbar Version: 3.5
Keywords: IE Cc: loudelement

Description

Icons of external plugin buttons are not displayed in IE7/IE8 in WYSIWYG mode. If switched to "source" mode, icons are displayed but dimmed (which is normal). When you switch back to WYSIWYG mode, some icons may show but still, they are dimmed.

If you change icon format from GIF to PNG, everything works as expected.

Attachments (2)

6909.patch (922 bytes) - added by garry.yao 6 years ago.
6909_2.patch (7.2 KB) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 6 years ago by alfonsoml

  • Cc loudelement added
  • Keywords IE added
  • Status changed from new to confirmed

#6944 has been marked as dup.

Confirmed with windows 2003, according to Garry, it works fine in windows 7.

comment:2 Changed 6 years ago by alfonsoml

  • Milestone set to CKEditor 3.5.1

#6964 has been marked as dup.

comment:3 Changed 6 years ago by alfonsoml

  • Component changed from General to UI : Toolbar

comment:4 Changed 6 years ago by wwalc

Confirmed on IE8, Windows 7 N 64bit. I have attached a sample plugin in #6964 for easier testing.

comment:5 Changed 6 years ago by alfonsoml

As reported in #6944 it can be checked also with the available "Placeholder" plugin.

comment:6 Changed 6 years ago by garry.yao

WFM on IE9,Win7, confirmed on IE8,XP, regression of [6421].

Changed 6 years ago by garry.yao

comment:7 Changed 6 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from confirmed to review

The hack of AlphaImageLoader doesn't work for GIF transparency, now the best option for us is to advocate PNG for toolbar icons.

comment:8 Changed 6 years ago by wwalc

  • Status changed from review to review_failed

The suggested fix does not solve the problem that people will have or already have with their own plugins. The common way of upgrading is simply downloading the new software without reading the list of changes, which means that we're doing a little surprise for the users.

Gif icons were not distorted with IE and zoom != 100% at all in previous versions of CKEditor, so why they should suddenly disappear from the toolbar if they didn't do anything wrong?

Changed 6 years ago by garry.yao

comment:9 Changed 6 years ago by garry.yao

  • Status changed from review_failed to review

Adding a patch reflecting Wiktor's idea - as the filter is required only for PNG, we could remove the alphaImageLoader filter from those icons that are apparently other format, like GIF in ticket tc.

comment:10 follow-up: Changed 6 years ago by Saare

  • Status changed from review to review_passed

Let's change the name to a clearer one, like "noalphapix".

comment:11 in reply to: ↑ 10 Changed 6 years ago by Saare

Replying to Saare:

Let's change the name to a clearer one, like "noalphapix".

Typo, "noalphafix" that is.

comment:12 Changed 6 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6319].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy