Ticket #6984 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Line breaks are lost when enter mode is br

Reported by: wwalc Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.3
Component: Core : Output Data Version: 3.4
Keywords: Cc:

Description

Confirmed in Firefox 3.6.13, Safari and Opera.

Steps to reproduce

  1. Open _samples/enterkey.html
  2. Set enter mode to BR
  3. switch to source mode, paste the following:
    <hr />
    <br />
    <br />
    <br />
    
  4. Switch to wysiwyg and back
  5. Result:
    <hr />
    <br />
    
  6. Two line breaks are lost whenever user switches to source mode and back

Regression introduced with [5750].

Note that the real problem in #5293 was unwanted line break in a "supposed to be empty" document so that developers could detect whether user typed something to create a page or not. It was not a problem with an extra line break at the end of the document with some real content.

Attachments

6984.patch (1.9 KB) - added by garry.yao 3 years ago.

Change History

comment:1 Changed 3 years ago by krst

  • Status changed from new to confirmed

Changed 3 years ago by garry.yao

comment:2 Changed 3 years ago by garry.yao

  • Status changed from confirmed to review
  • Owner set to garry.yao
  • Component changed from General to Core : Output Data

Actually a re-fix of #5293, in fact the original ticket had been overcomplicated.

comment:3 Changed 3 years ago by Saare

  • Status changed from review to review_passed

Please also remove what's in the brackets in line 403 inside htmlparser/fragment.js.

comment:4 Changed 3 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6458].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy