Ticket #7073 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Image dialog should not allow zero for width and height fields

Reported by: satya Owned by: Saare
Priority: Normal Milestone: CKEditor 3.5.3
Component: General Version: 3.0
Keywords: IBM Cc: damo,jamescun

Description (last modified by wwalc) (diff)

Image dialog allows zero to be entered for image width and height. When zero is entered the image is not visible and it is difficult to select and edit the image's properties.

The Image dialog also allows zero to be entered for Horizontal Space, Vertical Space and Border. A value of zero does not cause a visual effect, but an inline style is applied. The inline style should not be applied if it has no effect.

Either validation should not allow a value of zero, or zero can be allowed but it results in no inline style being applied.

Note: Microsoft Word does not allow a value of zero for image width and height.

Attachments

7073.patch (1.2 KB) - added by Saare 4 years ago.

Change History

comment:1 Changed 4 years ago by wwalc

  • Status changed from new to confirmed

comment:2 Changed 4 years ago by wwalc

  • Version set to 3.0

comment:3 Changed 4 years ago by alfonsoml

As I said previously, a zero value in those attributes besides width and height is perfectly valid, it has the effect of setting those attributes or styles to 0 overriding the default.

comment:4 Changed 4 years ago by wwalc

  • Description modified (diff)

I have corrected the description so that this ticket could remain valid. The other attributes were discussed earlier in #6488 as Alfonso already mentioned, 0 make sense there.

Changed 4 years ago by Saare

comment:5 Changed 4 years ago by Saare

  • Owner set to Saare
  • Status changed from confirmed to review

comment:6 Changed 4 years ago by wwalc

  • Milestone set to CKEditor 3.5.3

comment:7 Changed 4 years ago by garry.yao

  • Status changed from review to review_passed

comment:8 Changed 4 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6555].

comment:9 Changed 4 years ago by satya

when we add Zero for width or height it is showing an alert, but when user press OK button on Alert dialog, Image properties dialog getting closed & focus going back to editor body, instead of getting focus back to the Image Properties dialog. This needs to be fixed.

comment:10 Changed 4 years ago by garry.yao

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:11 Changed 4 years ago by garry.yao

  • Status changed from reopened to closed
  • Resolution set to fixed

Post fixing with [6589].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy