Opened 14 years ago
Closed 14 years ago
#7073 closed Bug (fixed)
Image dialog should not allow zero for width and height fields
Reported by: | Satya Minnekanti | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.5.3 |
Component: | General | Version: | 3.0 |
Keywords: | IBM | Cc: | Damian, James Cunningham |
Description (last modified by )
Image dialog allows zero to be entered for image width and height. When zero is entered the image is not visible and it is difficult to select and edit the image's properties.
The Image dialog also allows zero to be entered for Horizontal Space, Vertical Space and Border. A value of zero does not cause a visual effect, but an inline style is applied. The inline style should not be applied if it has no effect.
Either validation should not allow a value of zero, or zero can be allowed but it results in no inline style being applied.
Note: Microsoft Word does not allow a value of zero for image width and height.
Attachments (1)
Change History (12)
comment:1 Changed 14 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 14 years ago by
Version: | → 3.0 |
---|
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
Description: | modified (diff) |
---|
I have corrected the description so that this ticket could remain valid. The other attributes were discussed earlier in #6488 as Alfonso already mentioned, 0 make sense there.
Changed 14 years ago by
Attachment: | 7073.patch added |
---|
comment:5 Changed 14 years ago by
Owner: | set to Sa'ar Zac Elias |
---|---|
Status: | confirmed → review |
comment:6 Changed 14 years ago by
Milestone: | → CKEditor 3.5.3 |
---|
comment:7 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:8 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [6555].
comment:9 Changed 14 years ago by
when we add Zero for width or height it is showing an alert, but when user press OK button on Alert dialog, Image properties dialog getting closed & focus going back to editor body, instead of getting focus back to the Image Properties dialog. This needs to be fixed.
comment:10 Changed 14 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:11 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Post fixing with [6589].
As I said previously, a zero value in those attributes besides width and height is perfectly valid, it has the effect of setting those attributes or styles to 0 overriding the default.