Ticket #7114 (closed Bug: fixed)

Opened 4 years ago

Last modified 3 years ago

iframe plugin does not allow percentage widths

Reported by: effulgentsia Owned by: Saare
Priority: Normal Milestone: CKEditor 3.6.1
Component: General Version: 3.5
Keywords: IBM Cc: monahant@…

Description (last modified by krst) (diff)

Using Mac Firefox 3.6, CKEditor 3.5.1,

  • add an IFRAME to the textarea with the new iframe plugin / toolbar button.
  • Try to add "100%" as the width.

result:An error message comes back saying only numbers are allowed.
I suspect related to this, if you already have existing text content that contains HTML that includes an iframe with "100%" width, enabling CKEditor on that textarea converts the width to "100". This is a regression from CKEditor 3.4 which left iframes alone (though did not allow selecting them to make changes).

For anyone wishing to disable the iframe plugin until this is fixed, you can add "iframe" to config.removePlugins when calling CKEDITOR.replace(element, config) (see http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.html#.replace and http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.config.html#.removePlugins).

Attachments

7114.patch (6.3 KB) - added by Saare 3 years ago.
7114_2.patch (8.7 KB) - added by Saare 3 years ago.

Change History

comment:1 Changed 4 years ago by krst

  • Status changed from new to confirmed
  • Version changed from 3.5.1 to 3.5
  • Description modified (diff)

Confirmed for all browsers.
TC for second part of ticket:

  • add new iframe, width set to 100
  • in Source mode set its width to width="100%"
  • Switch back to WYSIWYG -> iframe is set to 100% width of edit area
  • Switch back to Source -> width is set back to 100

comment:2 Changed 3 years ago by tmonahan

  • Keywords IBM added
  • Cc monahant@… added

comment:3 Changed 3 years ago by Saare

  • Owner set to Saare
  • Status changed from confirmed to assigned

Changed 3 years ago by Saare

comment:4 Changed 3 years ago by Saare

  • Status changed from assigned to review

Changed 3 years ago by Saare

comment:5 Changed 3 years ago by Saare

Proposing another layout, as per Anna's suggestions.

comment:6 Changed 3 years ago by Saare

  • Status changed from review to closed
  • Resolution set to fixed
  • Milestone set to CKEditor 3.6.1

Fixed by #6462.

comment:7 Changed 3 years ago by jessebeach

This issue is related to #8586

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy