Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#7847 closed Bug (fixed)

JS error when editing a non-https image in CKEditor when hosted on https (SSL) in IE8

Reported by: Philippe Meunier Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.1
Component: General Version: 3.0
Keywords: Cc:

Description

We have a website which uses https (SSL) and CKEditor 3.6 runs within. The image plugin is enabled. When we load some content in CKEditor, and that content contains non-html images, a popup occurs under IE8, which ask if we want to load only secured content (and omit non-secure content). We answer yes. Some images are missing but still outlined in CKEditor. If we double click one of these image, the image dialog opens. If we try to accept the content of the dialog, it fails.

Please provide the following when reporting new bugs. The more information you provide, the quicker the bug may be solved:

Browser name and OS : Internet Explorer 8 in Windows XP

Screenshot : http://img40.imageshack.us/img40/3787/ckeditorbug.jpg

Attachments (1)

7847.patch (1.3 KB) - added by Garry Yao 13 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 13 years ago by Jakub Ś

Status: newconfirmed
Version: 3.0
  1. Paste (in html page) into textarea the following code.
    <p><img alt="" src="http://www.google.com/images/logos/ps_logo2.png" style="width: 364px; height: 126px" /></p>
    
  1. Open replacebycode sample in https and answer yes when IE asks you whether you want to load only secure content.
  2. Display image properties dialog.

Result: JS error is thrown:

Message: 'undefined' is empty or not an object
Row: 561
Char: 14
URI: /3.6/ckeditor/_source/plugins/image/dialogs/image.js

and you are not able to close the dialog by clicking OK.

You also are not able to close the image dialog with “OK” when you open the page in https, open image dialog, paste the following link - http://www.google.com/images/logos/ps_logo2.png and answer yes when IE asks you whether you want to load only secure content.

This has worked that way in IE8 from CKEditor 3.0

comment:2 Changed 13 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.1

comment:3 Changed 13 years ago by Garry Yao

For non-ssl resources work in WYSIWYG mode via https, you need to answer "no" on IE8's confirmation dialog, otherwise the image will not load and browser will prevent to alter it's src attribute, we can hardly do anything that helps.

comment:4 Changed 13 years ago by Frederico Caldeira Knabben

What makes this issue critical is that the dialog gets stuck, which can cause data loss. We need to at least avoid the js error, making the dialog still usable, even if missing some feature.

Changed 13 years ago by Garry Yao

Attachment: 7847.patch added

comment:5 Changed 13 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

comment:6 Changed 13 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:7 Changed 13 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7000]!

comment:8 in reply to:  3 Changed 13 years ago by Krzysztof Studnik

Replying to garry.yao:

For non-ssl resources work in WYSIWYG mode via https, you need to answer "no" on IE8's confirmation dialog, otherwise the image will not load and browser will prevent to alter it's src attribute, we can hardly do anything that helps.

IE6, CKEditor rev7024 - problem still occurs:

  • I answered No in IE6 confirmation dialog
  • Opened Image properties.
  • Without making any changes press OK

Result: JS error visible in IE status-bar

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy