Ticket #7947 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Table dialog should not allow negative values for width,height,Cell Spacing & Cell Padding

Reported by: satya Owned by: Saare
Priority: Normal Milestone: CKEditor 3.6.1
Component: UI : Dialogs Version: 3.6.1
Keywords: IBM Cc: damo, jamescun, tmonahan

Description

To reproduce the defect:

  1. Open CK Editor and click on Table icon.
  1. In Table Properties dialog enter negative vales for width(-200), height(-300),cell spacing(-10) & cell padding(-5).
  1. Click OK button.

Expected Result: An error dialog comes up with a waring message "width must be a whole number greater than zero".

Actual Result: Table inserted with no values set for width & height,negative values shown for Cell Spacing & Cell Padding but they have no impact when we see the table in WYSIWYG mode.

Attachments

7947.patch (704 bytes) - added by Saare 3 years ago.

Change History

comment:1 Changed 3 years ago by j.swiderski

  • Status changed from new to confirmed

True from rev [6979]

comment:2 Changed 3 years ago by j.swiderski

This revision has also caused ticket #7948

Changed 3 years ago by Saare

comment:3 Changed 3 years ago by Saare

  • Owner set to Saare
  • Status changed from confirmed to review

comment:4 Changed 3 years ago by garry.yao

  • Status changed from review to review_passed
  • Component changed from General to UI : Dialogs

It's ok, thought negative length is explicitly defined as valid for CSS, it's mostly useful in position style only (e.g. left,top) which doesn't affect our current dialog system yet, which could be handled later as special cases.

comment:5 Changed 3 years ago by fredck

  • Milestone set to CKEditor 3.6.1

comment:6 Changed 3 years ago by Saare

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6994].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy