Link editor freezes when comments exists between tables

[bmohrct]

This bug was reported as fixed in ticket #8232 but I am able to replicate the fix. The style/plugin.js file does not exist in my /plugins/style dir. I have however been able to better narrow down the issue. It is not an option for me to delete comments since this fix applies to many preexisting files.

I replicated the issue in the ckeditor demo by creating two tables with a HTML comment between each table. Then added text to a cell after the comment and tried to make it a link. The link editor freezes. The following HTML will create the same error:

<table>
	<tbody>
		<tr>
			<td>
				&nbsp;</td>
			<td>
				&nbsp;</td>
		</tr>
	</tbody>
</table>
<!-- TEST COMMENT -->
<table>
	<tbody>
		<tr>
			<td>
				asdf</td>
			<td>
				&nbsp;</td>
		</tr>
	</tbody>
</table>
<p>
	&nbsp;</p>

The result adds span tags around the text and does not create a link.

This was replicated FF on OSX.

[Jakub Ś]

Issue is reproducible in all browsers from CKEditor 3.0.

Message: sibling.is is not a function.
Line: 1032
URI: /3.6.2/ckeditor/_source/core/dom/range.js

[bmohrct]

Are there any updates or ETA for this bug? It is currently preventing up from migrating to ckeditor.

[bmohrct]

I have confirmed that this issue still occure in 3.6.2. Is there any plan to address this in the near future. It has prevented up from upgrading.

[Garry Yao]

Target to milestone because of the bug severity.

[Jakub Ś]

@bmohrct - could you perhaps test the patch provided by @garry.yao and see if it works?

[Garry Yao]

Fixed with [7372].

[Wiktor Walc]

Just a note, that the constructor variable used in the patch for ​node.js is not accepted by Rhino (org.mozilla.javascript.Parser). The returned error is "identifier is a reserved word" - the variable name must be changed into anything else.

[Garry Yao]

Ok, this's addressed with [7375].