Focus not going back to correct field on Cell Properties after we close Select Color dialog using OK & Cancel buttons

[Satya Minnekanti]

To reproduce the defect:

1. Open any CK Editor sample & insert a table.

2. Open Content menu and click on Cell -> Cell Properties option.

3. Cell Properties dialog opened.

4. Click on Choose button next to Background Color.

5. Select Color dialog opened.

Scenario 1:

Select a color in the Color list box and press OK button.

Expected Result: Select Color dialog closed, selected color gets applied to Background color and focus should go back to Choose button next to Background Color text field.

Actual Result: Select Color dialog closed, selected color gets applied to Background color but focus going to next field which is Border Color text field.

Scenario 2:

Select a color in the Color list box and press Cancel button.

Expected Result: Select Color dialog closed, no color applied to Background color and focus should go back to Choose button next to Background Color text field.

Actual Result: Select Color dialog closed, no color applied to Background color but focus going back to Background Color text field instead of Choose button next to it.

Same issue happens when we select Border Color and click OK & Cancel buttons on Select Color dialog

Focus going to next field after Choose button when we click OK button to close Select Color dialog

Focus going to previous field before Choose button when we click Cancel button to close Select Color dialog

[Jakub Ś]

Reproducible in all browsers from CKEditor 3.4.1

[Garry Yao]

There's a coding style issue at _source/plugins/dialogui/plugin.js#L979 pls fix that on commit.

Please make sure a changelog entry is committed along with the patch as well.

[Piotrek Koszuliński]

Fixed coding style for last patch

[Piotrek Koszuliński]

Fixed with [7364].