Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#8698 closed Bug (fixed)

Can't close Select Colour dialog using Esc

Reported by: satya Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.6.3
Component: Accessibility Version: 3.0.1
Keywords: IBM Cc: damo, tmonahan

Description

To reproduce the defect:

  1. Open any CK Editor sample & insert a table.
  1. Open Content menu and click on Cell -> Cell Properties option.
  1. Cell Properties dialog opened.
  1. Click on Choose button next to Background Color or Border Color text field.
  1. Select Colour dialog opened.
  1. Now press Esc.

Expected Result: Select Color dialog closed & focus goes back to Choose button next to Background Color or Border Color text field.

Actual Result: Select Color dialog not closed.

Attachments (1)

8698.patch (1.2 KB) - added by garry.yao 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by j.swiderski

  • Component changed from General to Accessibility
  • Status changed from new to confirmed
  • Version set to 3.0.1

Reproducible in all browsers from CKEditor 3.0.1

comment:2 Changed 4 years ago by j.swiderski

Other tickets that fall under Select "Color Dialog Problems / Enchancements":
#8706, #8701, #8519, #8679, #8523, #8218, #5960, #4994.

Changed 4 years ago by garry.yao

comment:3 Changed 4 years ago by garry.yao

  • Milestone set to CKEditor 3.6.3
  • Owner set to garry.yao
  • Status changed from confirmed to review

comment:4 Changed 4 years ago by fredck

  • Status changed from review to review_passed

Just to make it confusing, please remove "Also register key handlers if first dialog" comment line when committing.

comment:5 Changed 4 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [7370] and [7371].

comment:6 Changed 4 years ago by satya

I could still reproduce this issue on nightly build & i can't close Select Colour dialog using Esc key. Please re-open this defect.

comment:7 Changed 4 years ago by fredck

  • Resolution fixed deleted
  • Status changed from closed to reopened

Confirmed, I can reproduce it with FF by following the ticket tc. It works well only when opening the dialog directly through the color buttons in the toolbar.

comment:8 Changed 4 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from reopened to closed

It's mistake, that only part of the patch (#8701) was committed, compensate the commit with [7408].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy