Ticket #8887 (closed Bug: fixed)

Opened 3 years ago

Last modified 2 years ago

Kama skin: dialog.css error

Reported by: insad Owned by: j.swiderski
Priority: Normal Milestone: CKEditor 3.6.4
Component: UI : Skins Version:
Keywords: Firefox Webkit Cc:

Description (last modified by wwalc) (diff)

In Kama.skin - dialog.css, the background position for a.cke_dialog_ui_button should be 0 -1068px instead of 0 -1069px as now, in order to avoid an ugly hover effect (very visible if the default button colors are changed to darker colors in sprites.png - the bad hover effect can be seen for instance on the "Browse Server" button in the image plugin):

line 364 of kawa skin dialog.css

background: transparent url(images/sprites.png) repeat-x scroll 0 -1069px;

should be

background: transparent url(images/sprites.png) repeat-x scroll 0 -1068px;

Attachments

sprites.png (7.3 KB) - added by insad 3 years ago.
button.png (46.4 KB) - added by j.swiderski 3 years ago.
8887.patch (531 bytes) - added by j.swiderski 3 years ago.

Change History

comment:1 Changed 3 years ago by j.swiderski

very visible if the default button colors are changed to darker colors in sprites.png

Could I ask you to provide this file with darker colors you use?

Changed 3 years ago by insad

comment:2 Changed 3 years ago by insad

The file has been attached. The problem is visible on the 'Browse Server' button in the image plugin. It's also visible in http://ckeditor.com/demo if you click to insert an image with the original sprites.png file - if you watch carefully on mouse-over of the 'Browse Server' button, you'll see the yellow mouse-over like jumping in relation to the blue non-mouse-over. If you open the sprites.png with e.g. photoshop and zoom in, you'll see the blue background starts at pixel-Y 1068 (counting from 0), not 1069.

comment:3 Changed 3 years ago by j.swiderski

  • Status changed from new to confirmed
  • Keywords kawa, dialog, dialog_ui_button removed
  • Version 3.6.2 deleted

Thank you for pointing that out, now I can see it clearly.

To reproduce just hover over the BrowseServer Button and observe the bottom line (See button.png)

Changed 3 years ago by j.swiderski

comment:4 Changed 3 years ago by j.swiderski

  • Owner set to j.swiderski
  • Status changed from confirmed to assigned

Changed 3 years ago by j.swiderski

comment:5 Changed 3 years ago by j.swiderski

  • Keywords Firefox Webkit added
  • Status changed from assigned to review

This tiny change proposed by @insad fixed one pixel issue in Webkit and Firefox.

There is still a problem in IE6 but it is independent of this ticket. Reported here for IE6: #8907

comment:6 Changed 2 years ago by fredck

  • Status changed from review to review_passed
  • Milestone set to CKEditor 3.6.4

comment:7 Changed 2 years ago by j.swiderski

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [7530].

comment:8 Changed 2 years ago by wwalc

  • Description modified (diff)
  • Summary changed from Kawa skin: dialog.css error to Kama skin: dialog.css error
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy