Ticket #3389: 3389_5.patch

_source/plugins/menu/plugin.js

@@ -77 +77 @@
                                         return;
                                 }
 
+                                // Record parent menu focused item first(#3389).
+                                var block = this._.panel.getBlock( this.id );
+                                block._.focusIndex = index;
+
+
                                 // Create the submenu, if not available, or clean the existing
                                 // one.
                                 if ( menu )
@@ -86 +91 @@
                                         menu = this._.subMenu = new CKEDITOR.menu( this.editor, this._.level + 1 );
                                         menu.parent = this;
                                         menu.onClick = CKEDITOR.tools.bind( this.onClick, this );
+                                        // Sub menu use their own scope for binding onEscape.
+                                        menu.onEscape = this.onEscape;
                                 }
 
                                 // Add all submenu items to the menu.
@@ -138 +145 @@
                                                 },
                                                 this._.level);
 
-                                        panel.onEscape = CKEDITOR.tools.bind( function()
+                                        panel.onEscape = CKEDITOR.tools.bind( function( keystroke )
                                         {
-                                                this.onEscape && this.onEscape();
-                                                this.hide();
+                                                if ( this.onEscape && this.onEscape( keystroke ) === false )
+                                                        return false;
                                         },
                                         this );
 
@@ -161 +168 @@
                                         keys[ 38 ]      = 'prev';                                       // ARROW-UP
                                         keys[ CKEDITOR.SHIFT + 9 ]      = 'prev';       // SHIFT + TAB
                                         keys[ 32 ]      = 'click';                                      // SPACE
-                                        keys[ 39 ]      = 'click';                                      // ARROW-RIGHT
+                                        keys[ ( editor.lang.dir == 'rtl' ? 37 : 39 ) ]  = 'click';  // ARROW-RIGHT/ARROW-LEFT(rtl)
 
                                         element = this._.element = block.element;
                                         element.addClass( editor.skinClass );

_source/core/dom/node.js

@@ -25 +25 @@
         {
                 switch ( domNode.nodeType )
                 {
+                        // Safari don't consider document as element node type(#3389).
+                        case CKEDITOR.NODE_DOCUMENT :
+                                return new CKEDITOR.dom.document( domNode );
+
                         case CKEDITOR.NODE_ELEMENT :
                                 return new CKEDITOR.dom.element( domNode );
 
@@ -49 +53 @@
 CKEDITOR.NODE_ELEMENT = 1;
 
 /**
+ * Document node type.
+ * @constant
+ * @example
+ */
+CKEDITOR.NODE_DOCUMENT = 9;
+
+/**
  * Text node type.
  * @constant
  * @example

_source/plugins/floatpanel/plugin.js

@@ -153 +153 @@
 
                                         focused.on( 'blur', function( ev )
                                                 {
-                                                        if ( CKEDITOR.env.ie && !this.allowBlur() )
-                                                                return;
-
                                                         // As we are using capture to register the listener,
                                                         // the blur event may get fired even when focusing
                                                         // inside the window itself, so we must ensure the
                                                         // target is out of it.
-                                                        var target = ev.data.getTarget(),
-                                                                targetWindow = target.getWindow && target.getWindow();
-
-                                                        if ( targetWindow && targetWindow.equals( focused ) )
+                                                        var target;
+                                                        if ( CKEDITOR.env.ie && !this.allowBlur()
+                                                                 || ( target = ev.data.getTarget() )
+                                                                      && target.getName && target.getName() != 'iframe' )
                                                                 return;
 
                                                         if ( this.visible && !this._.activeChild && !isShowing )
@@ -184 +181 @@
                                         this._.blurSet = 1;
                                 }
 
-                                panel.onEscape = CKEDITOR.tools.bind( function()
+                                panel.onEscape = CKEDITOR.tools.bind( function( keystroke )
                                         {
-                                                this.onEscape && this.onEscape();
+                                                if ( this.onEscape && this.onEscape( keystroke ) === false );
+                                                        return false;
                                         },
                                         this );
 

_source/plugins/panel/plugin.js

@@ -171 +171 @@
 
                                 doc.on( 'keydown', function( evt )
                                         {
-                                                var keystroke = evt.data.getKeystroke();
+                                                var keystroke = evt.data.getKeystroke(),
+                                                        dir = this.document.getById( 'cke_' + this.id ).getAttribute( 'dir' );
 
                                                 // Delegate key processing to block.
                                                 if ( this._.onKeyDown && this._.onKeyDown( keystroke ) === false )
@@ -180 +181 @@
                                                         return;
                                                 }
 
-                                                if ( keystroke == 27 )          // ESC
-                                                        this.onEscape && this.onEscape();
+                                                // ESC/ARROW-LEFT/ARROW-RIGHT(rtl)
+                                                if ( keystroke == 27 || keystroke == ( dir == 'rtl' ? 39 : 37 ) )
+                                                        if ( this.onEscape && this.onEscape( keystroke ) === false );
+                                                                evt.data.preventDefault();
                                         },
                                         this );
 
@@ -258 +261 @@
                 this.element.disableContextMenu();
         },
 
-        _ : {},
-
+        _ : {
+                
+                /**
+                 * Mark the item specified by the index as current activated. 
+                 */
+                markItem: function( index )
+                {
+                        if ( index == -1 )
+                                return;
+                        var links = this.element.getElementsByTag( 'a' );
+                        var item = links.getItem( this._.focusIndex = index );
+
+                        // Safari need focus on the iframe window first(#3389), but we need
+                        // lock the blur to avoid hiding the panel.
+                        if ( CKEDITOR.env.webkit )
+                                item.getDocument().getWindow().focus();
+                        item.focus();
+                }
+        },
+
         proto :
         {
                 show : function()

_source/plugins/contextmenu/plugin.js

@@ -68 +68 @@
                                         noUnlock = false;
                                 }, this );
 
-                                menu.onEscape = function()
+                                menu.onEscape = function( keystroke )
                                 {
-                                        editor.focus();
-
-                                        if ( CKEDITOR.env.ie )
-                                                editor.getSelection().unlock( true );
+                                        var parent = this.parent;
+                                        // 1. If it's sub-menu, restore the last focused item
+                                        // of upper level menu.
+                                        // 2. In case of a top-menu, close it.
+                                        if( parent )
+                                        {
+                                                parent._.panel.hideChild();
+                                                // Restore parent block item focus.
+                                                var parentBlock = parent._.panel._.panel._.currentBlock,
+                                                        parentFocusIndex =  parentBlock._.focusIndex;
+                                                parentBlock._.markItem( parentFocusIndex );
+                                        }
+                                        else if ( keystroke == 27 )
+                                        {
+                                                this.hide();
+                                                editor.focus();
+        
+                                                if ( CKEDITOR.env.ie )
+                                                        editor.getSelection().unlock( true );
+                                        }
+                                        return false;
                                 };
                         }
 
@@ -140 +157 @@
 
                                         CKEDITOR.tools.setTimeout( function()
                                                 {
-                                                        this._.onMenu( offsetParent, null, offsetX, offsetY );
+                                                        this.show( offsetParent, null, offsetX, offsetY );
                                                 },
                                                 0, this );
                                 },