Opened 16 years ago

Closed 15 years ago

#3389 closed Bug (fixed)

Keystroke for open/close submenu

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.2
Component: Accessibility Version:
Keywords: IBM Confirmed Cc:

Description

There' no key assigned to help collapse submenu and go back to the first-level menu.

Attachments (5)

3389.patch (3.9 KB) - added by Garry Yao 16 years ago.
3389_2.patch (4.5 KB) - added by Garry Yao 15 years ago.
3389_3.patch (7.3 KB) - added by Garry Yao 15 years ago.
3389_4.patch (5.7 KB) - added by Garry Yao 15 years ago.
3389_5.patch (6.7 KB) - added by Garry Yao 15 years ago.

Download all attachments as: .zip

Change History (23)

Changed 16 years ago by Garry Yao

Attachment: 3389.patch added

comment:1 Changed 16 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

Arrow-Left OR ESC is assigned to do the job, I'll update user-guide after closing this ticket.

comment:2 Changed 16 years ago by Garry Yao

The patch is containing the latest change of #3390 for easy reviewing.

comment:3 Changed 16 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.1

comment:4 Changed 16 years ago by Frederico Caldeira Knabben

Summary: Keystrike for open/close submenuKeystroke for open/close submenu

comment:5 Changed 15 years ago by Garry Yao

Keywords: IBM added; Review? removed

#3951 has been marked as DUP.

comment:6 Changed 15 years ago by Damian

Garry I think you meant #3952

comment:7 Changed 15 years ago by Artur Formella

Component: GeneralAccessibility

Changed 15 years ago by Garry Yao

Attachment: 3389_2.patch added

comment:8 Changed 15 years ago by Garry Yao

Keywords: Review? added; Confirmed removed

Making necessary changes since it's quite a old patch.

comment:9 Changed 15 years ago by Tobiasz Cudnik

Keywords: Review- Confirmed added; Review? removed

There are problems on Safari4, reproduce like this:

  • Open context menu with submenu options (eg for table)
  • Move cursor to option with submenu
  • Press right arrow
  • Press left arrow

Expected: focus is back to previous option with submenu, option is highlighted and we can navigate up/down.

Actual: focus is missing, up/down navigation is impossible

Changed 15 years ago by Garry Yao

Attachment: 3389_3.patch added

comment:10 Changed 15 years ago by Garry Yao

Keywords: Review? added; Review- removed

Changed 15 years ago by Garry Yao

Attachment: 3389_4.patch added

comment:11 Changed 15 years ago by Garry Yao

Provide a much more simplified patch.

comment:12 Changed 15 years ago by Tobiasz Cudnik

Keywords: Review- added; Review? removed

Patch works fine with one minor issue - in RTL mode, arrow which opens submenu should be reverted (from right to left).

comment:13 Changed 15 years ago by Garry Yao

Milestone: CKEditor 3.1CKEditor 3.0.1

Changed 15 years ago by Garry Yao

Attachment: 3389_5.patch added

comment:14 Changed 15 years ago by Garry Yao

Keywords: Review? added; Review- removed

Incoming patch take care about the direction convention.

comment:15 Changed 15 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.1CKEditor 3.2

comment:16 Changed 15 years ago by Frederico Caldeira Knabben

#4804 has been marked as DUP.

comment:17 Changed 15 years ago by Garry Yao

Keywords: Review? removed

Changes are checked in with [4977] on aria branch.

comment:18 Changed 15 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5092] in 3.2.x branch.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy