Opened 8 years ago
Closed 8 years ago
#3951 closed Bug (fixed)
Reset size and lock ratio options not accessible in Image dialog
| Reported by: | Damian | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Dialogs | Version: | |
| Keywords: | IBM Confirmed Review+ | Cc: |
Description
The two options "reset size" and "lock ratio" are not keyboard accessible.
Attachments (3)
Change History (10)
comment:1 Changed 8 years ago by
| Component: | General → UI : Dialogs |
|---|---|
| Keywords: | Confirmed added |
| Owner: | set to Tobiasz Cudnik |
| Status: | new → assigned |
Changed 8 years ago by
| Attachment: | 3951.patch added |
|---|
comment:2 Changed 8 years ago by
| Keywords: | Review? added |
|---|
Changed 8 years ago by
| Attachment: | 3951_2.patch added |
|---|
comment:3 Changed 8 years ago by
Corrected one unsatisfied reference, some coding style and added changelog entry.
comment:4 Changed 8 years ago by
| Keywords: | Review- added; Review? removed |
|---|
As discussed with Tobiasz, the inner closure 'addFocusable' should be extracted.
Changed 8 years ago by
| Attachment: | 3951_3.patch added |
|---|
comment:5 Changed 8 years ago by
| Keywords: | Review? added; Review- removed |
|---|
I've relocated Focusable declaration and removed module pattern. Also dialog reference is now passed as constructor parameter.
comment:6 Changed 8 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
This is a very good solution.
Note: See
TracTickets for help on using
tickets.
I'm introducing new dialog's method addFocusable, which allows any element to be easily added to dialog's focus list. Keyboard events are transparently converted to mouse equivalents.
Element have to be browser-focusable to this to work.