Ticket #3758: 3758.patch

_source/plugins/dialog/plugin.js

@@ -73 +73 @@
                 return null;
         }
 
+        function deepCloneArray( list )
+        {
+                var retval = [];
+
+                for ( var i = 0 ; i < list.length ; i++ )
+                {
+                        if ( typeof( list[ i ].pop ) == 'function' )
+                                retval.push( deepCloneArray( list[ i ] ) );
+                        else if ( typeof( list[ i ] ) == 'object' )
+                                retval.push( deepClone( list[ i ] ) );
+                        else
+                                retval.push( list[ i ] );
+                }
+
+                return retval;
+        }
+
+        function deepClone( obj )
+        {
+                var retval = {};
+
+                for ( var i in obj )
+                {
+                        var value = obj[ i ];
+                        if ( typeof( value.pop ) == 'function' )
+                                retval[ i ] = deepCloneArray( value );
+                        else if ( typeof( value ) == 'object' )
+                                retval[ i ] = deepClone( value );
+                        else
+                                retval[ i ] = value;
+                }
+
+                return retval;
+        }
+
         // Stores dialog related data from skin definitions. e.g. margin sizes.
         var skinData = {};
 
@@ -96 +131 @@
                 }
 
                 // Completes the definition with the default values.
-                definition = CKEDITOR.tools.extend( definition( editor ), defaultDialogDefinition );
+                definition = deepClone( CKEDITOR.tools.extend( definition( editor ), defaultDialogDefinition ) );
 
                 // Create a complex definition object, extending it with the API
                 // functions.