Opened 16 years ago
Closed 16 years ago
#3758 closed New Feature (fixed)
Add support to change the dialog definition in selected editor
Reported by: | Wiktor Walc | Owned by: | Martin Kou |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | UI : Dialogs | Version: | |
Keywords: | Confirmed Review+ Doc | Cc: |
Description
When the dialogDefinition event is fired it is possible to change the global dialog definition, but it is not possible to change the dialog definition just for the selected editor instance.
Attachments (3)
Change History (13)
Changed 16 years ago by
Attachment: | 3758.patch added |
---|
comment:1 Changed 16 years ago by
Keywords: | Review? added |
---|
comment:2 Changed 16 years ago by
Owner: | set to Martin Kou |
---|---|
Status: | new → assigned |
comment:3 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
- The cloning logic is broken. It doesn't handle null properties. (The table dialog doesn't work)
- At this point, we should instead enhance the CKEDITOR.tools.clone function to make it support arrays, using it instead of custom local functions.
- Please ensure you have things tested before the new patch. This is a drastic change, which needs much attention.
Changed 16 years ago by
Attachment: | 3758_2.patch added |
---|
comment:4 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:5 Changed 16 years ago by
After this patch, only the following types will be allowed in a dialog definition:
- undefined
- null
- Number
- Boolean
- String
- Date
- Function
- Array
- Literal Object
Things outside of the types listed above, e.g. regex objects and DOM objects, will result in cloning errors.
comment:6 Changed 16 years ago by
Keywords: | Doc? added |
---|
Changed 16 years ago by
Attachment: | 3758_3.patch added |
---|
comment:7 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
The cloning logic could be further simplified, it's using a lot of 'instanceof' operator and inner function, and it's not necessary for split array and object iteration.
comment:8 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
Simplified the patch with Fred's suggestions.
comment:9 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:10 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed with [3704].
Click here for more info about our SVN system.
Patch added by Martin in #3673