Ticket #3758: 3758_3.patch

_source/plugins/dialog/plugin.js

@@ -98 +98 @@
                 // Completes the definition with the default values.
                 definition = CKEDITOR.tools.extend( definition( editor ), defaultDialogDefinition );
 
+                // Clone a functionally independent copy for this dialog.
+                definition = CKEDITOR.tools.clone( definition );
+
                 // Create a complex definition object, extending it with the API
                 // functions.
                 definition = new definitionObject( this, definition );

_source/core/tools.js

@@ -38 +38 @@
 
                 /**
                  * Creates a deep copy of an object.
-                 * Attention: there is no support for deep copy of Array properties and
-                 * for recursive references.
+                 * Attention: there is no support for recursive references.
                  * @param {Object} object The object to be cloned.
                  * @returns {Object} The object clone.
                  * @example
@@ -60 +59 @@
                  * alert( obj.cars.Porsche.color );     // red
                  * alert( clone.cars.Porsche.color );   // silver
                  */
-                clone : function( object )
+                clone : function( obj )
                 {
-                        if( object === null || typeof( object ) != 'object')
-                                return object;
+                        var clone;
 
-                        var clone = new object.constructor();
+                        // Array.
+                        if ( obj && ( obj instanceof Array ) )
+                        {
+                                clone = [];
+                                
+                                for ( var i = 0 ; i < obj.length ; i++ )
+                                        clone[ i ] = this.clone( obj[ i ] );
+                                
+                                return clone;
+                        }
 
-                        for ( var propertyName in object )
+                        // "Static" types.
+                        if ( obj === null 
+                                || ( typeof( obj ) != 'object' )
+                                || ( obj instanceof String )
+                                || ( obj instanceof Number )
+                                || ( obj instanceof Boolean )
+                                || ( obj instanceof Date ) )
                         {
-                                var property = object[ propertyName ];
+                                return obj;
+                        }
+
+                        // Objects.
+                        clone = new obj.constructor();
+
+                        for ( var propertyName in obj )
+                        {
+                                var property = obj[ propertyName ];
                                 clone[ propertyName ] = this.clone( property );
                         }