Ticket #4084: 4084_2.patch

CHANGES.html

@@ -162 +162 @@
                         ckeditor2.html test case.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/3989">#3989</a> : Host page horizontal scrolling a lot when on having righ-to-left direction.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/4001">#4001</a> : Create link around existing image result incorrect.</li>
+                <li><a href="http://dev.fckeditor.net/ticket/4084">#4084</a> : In Firefox image dialog using Kama skin was sticked to left viewport border.</li>
         </ul>
         <h3>
                 CKEditor 3.0 RC</h3>

_source/plugins/dialog/plugin.js

@@ -642 +643 @@
                         this._.hasFocus = false;
 
                         // Rearrange the dialog to the middle of the window.
-                        CKEDITOR.tools.setTimeout( function()
-                                {
-                                        var viewSize = CKEDITOR.document.getWindow().getViewPaneSize();
-                                        var dialogSize = this.getSize();
+                        var viewSize = CKEDITOR.document.getWindow().getViewPaneSize();
 
-                                        this.move( ( viewSize.width - dialogSize.width ) / 2, ( viewSize.height - dialogSize.height ) / 2 );
+                        // We're using definition size for initial position because of
+                        // offten corrupted data in offsetWidth at this point. (#4084)
+                        this.move( ( viewSize.width - definition.minWidth ) / 2, ( viewSize.height - definition.minHeight ) / 2 );
 
-                                        this.parts.dialog.setStyle( 'visibility', '' );
+                        this.parts.dialog.setStyle( 'visibility', '' );
 
-                                        // Execute onLoad for the first show.
-                                        this.fireOnce( 'load', {} );
-                                        this.fire( 'show', {} );
+                        // Execute onLoad for the first show.
+                        this.fireOnce( 'load', {} );
+                        this.fire( 'show', {} );
 
-                                        // Save the initial values of the dialog.
-                                        this.foreach( function( contentObj ) { contentObj.setInitValue && contentObj.setInitValue(); } );
-
-                                },
-                                100, this );
-                },
+                        // Save the initial values of the dialog.
+                        this.foreach( function( contentObj ) { contentObj.setInitValue && contentObj.setInitValue(); } );
+                },
 
                 /**
                  * Executes a function for each UI element.