Strip entire element after removing required attr/style

[Piotrek Koszuliński]

E.g. <a name=""></a> should be removed when name attribute was filtered out.

Similar case: currently <span> is allowed because plugins like font, colorbutton allow styles which base on span elements. So when pasting e.g. <span lang="pl">, lang is filtered out, but <span> left.

Proposed fix:

There should be a way to mark attrs/style/class as required. Element is marked by this rule as valid (element has to be valid, otherwise it will be filtered out) only if it has this required property.

Possible format:

"a[!href]; span{!color}"

PS. Plugins like font and colorbutton use styles to register content they generate, so by default when passing style to filter#allow() all parts of style should be marked as required.

[Piotrek Koszuliński]

It doesn't make sense to restrict this to inline content only. I can't see any case in which block element without some property should be removed, but theoretically <a> as HTML5's transparent element may become a block one.

[Piotrek Koszuliński]

Pushed ​t/10006 on dev and tests. Both branches are based on #9989.

[Piotrek Koszuliński]

Rebased branches on t/9989.

[Piotrek Koszuliński]

Merged to major on ​git:3a9b2c5 on dev and 33387db on tests.

[Wim Leers]

Looks great.

And the syntax makes sense (cfr. CSS'!important).

[Piotrek Koszuliński]

In fact !important means 'not important' :D. But I'm glad that you liked our syntax :).

[Wim Leers]

That's a good point :)

But fact is of course that that is not what the CSS syntax is trying to convey :)

So, let me restate: from a "typical programming language POV" it makes no sense, but it's analogous to the CSS syntax, so it does makes sense in this context!