Opened 11 years ago
Closed 11 years ago
#10112 closed Bug (fixed)
Fix focusManager test
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.1 RC |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
Failing: http://ckeditor4.t/dt/core/focusManager/focus.html
Test named "test add focus targets" failed with message: "Timeout: wait() called but resume() never called.".
First bad commit: git:fe21f84
Fails only in release env.
Change History (5)
comment:1 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | new → assigned |
comment:2 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:3 Changed 11 years ago by
Since git:fe21f84 toolbar is created on editor#load, not #contentDom. Sometimes it may happen that focus or other event that executes layout() function were fired when there's no editable (before contentDom or e.g. when switching from one editable to another). So instead of patching tests I think that it's better to ensure that editable exists.
comment:4 Changed 11 years ago by
| Status: | review → review_passed |
|---|
comment:5 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on major with git:eaf5e73.
Note: See
TracTickets for help on using
tickets.
Pushed t/10112 on dev.