Opened 6 years ago

Last modified 6 years ago

#10142 confirmed Bug

CKBuilder: Closure Compiler thinks native is a reserved keyword

Reported by: Wiktor Walc Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description (last modified by Wiktor Walc)

It it impossible to build CKEditor after this change: a2136ce (native is a reserved keyword). I remember that it happened at least once in the past. We renamed the "native" variable to "nativ".

After a quick research it turned out we may get rid of this issue forever by using this piece of code:

options.setLanguageIn( CompilerOptions.LanguageMode.ECMASCRIPT5 );

native was a future reserved word in ECMAScript v3. Closure Compiler follows ES4, which also lists native as a reserved keyword.

However, I believe it will be quite unsafe to switch CC to ES5 mode at this moment, because this time we may not notice code that will be incompatible with IE7.

Change History (3)

comment:1 Changed 6 years ago by Wiktor Walc

Description: modified (diff)

comment:2 Changed 6 years ago by Piotrek Koszuliński

Status: newconfirmed

CC, please.

comment:3 Changed 6 years ago by Piotrek Koszuliński

Version: 4.0.2
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy