Opened 10 years ago

Closed 10 years ago

#1019 closed Bug (fixed)

FCKTableCommand are not context sensitive

Reported by: Jon Håvard Gundersen Owned by:
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed HasPatch Cc:

Description

The FCKTableCommand class is not context sensitive and this causes the icons from the tablecommands plugin to always be active even if the user is outside of a table.

It should be easy to add correct GetState function to this class.

Something like:

if(FCK.EditorDocument != null){

if(FCKSelection.HasAncestorNode('TABLE')){

return FCK_TRISTATE_OFF ;

}

} return FCK_TRISTATE_DISABLED;

Change History (2)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed HasPatch added
Milestone: FCKeditor 2.5
Version: SVN

Good point, and your proposal is seams to be the correct way to implement it. Thanks for it.

comment:2 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: newclosed

Fixed with [646].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy