Data processor breaks *-href attributes on links

[Piotrek Koszuliński]

Reported on SO: ​http://stackoverflow.com/questions/15795142/is-there-anyway-to-stop-ckeditor-4-from-filtering-my-anchor-tag-attributes

Open editor with disabled ACF.

Set data: <p><a href="#" data-href="x">foo</a></p>

Result: <p><a data-="" href="#">foo</a></p>

All link attributes ending with /[^a-z]href are broken

[Jakub Ś]

Problem can be reproduced in all browsers from CKEditor 3.5.1

[Oskar Schöldström]

Some additional information:

• Using the Drupal CKEditor module with version 4.1.1, the editor is able to save the attribute correctly, but strips it once the WYSIWYG is loaded.
• Still happens when all plugins except for wysiwygarea are disabled.

[Oskar Schöldström]

I submitted a pull request on github. ​https://github.com/ckeditor/ckeditor-dev/pull/38

The issue is that a regex matching protected attributes uses a \b-modifier, and as the - character is not a word-character the full attribute name will get split at the dash.

[Piotrek Koszuliński]

This is broken from the beginning - #6665.

[Piotrek Koszuliński]

Replying to oxy:

I submitted a pull request on github. ​https://github.com/ckeditor/ckeditor-dev/pull/38

The issue is that a regex matching protected attributes uses a \b-modifier, and as the - character is not a word-character the full attribute name will get split at the dash.

Unfortunately this is not a correct patch. It breaks e.g.:

toHtml( <p><img onmouseout="this.src=\'out.png\'" onmouseover="this.src=\'over.png\'" src="http://t/image.png" /></p>

Expected:
<p><img data-cke-pa-onmouseout="this.src='out.png'" data-cke-pa-onmouseover="this.src='over.png'" data-cke-saved-src="http://t/image.png" src="http://t/image.png" /></p>
Actual:
<p><img data-cke-pa-onmouseout="this.src='out.png'" data-cke-pa-onmouseover="this.src='over.png'" data-cke-saved-="" src="http://t/image.png" /></p>

basic case like this:

toHtml( '<a\n href="http://ckeditor.com">foo</a>' )

Expected:
<a data-cke-saved-href="http://ckeditor.com" href="http://ckeditor.com">foo</a>
Actual:
<a data-cke-saved-="" href="http://ckeditor.com">foo</a>

and does not fix the issue:

toHtml( '<p><a data-href="x" href="#" src-foo="y">A</a></p>' )

Expected:
<p><a data-cke-saved-href="#" data-href="x" href="#" src-foo="y">A</a></p>
Actual:
<p><a data-cke-saved-="" data-href="x" href="#" src-foo="y">A</a></p>

[Piotrek Koszuliński]

I pushed t/10298 branch on tests.

[Oskar Schöldström]

Replying to Reinmar:

Replying to oxy:

I submitted a pull request on github. ​https://github.com/ckeditor/ckeditor-dev/pull/38

The issue is that a regex matching protected attributes uses a \b-modifier, and as the - character is not a word-character the full attribute name will get split at the dash.

Unfortunately this is not a correct patch. It breaks e.g.:

toHtml( <p><img onmouseout="this.src=\'out.png\'" onmouseover="this.src=\'over.png\'" src="http://t/image.png" /></p>

Expected:
<p><img data-cke-pa-onmouseout="this.src='out.png'" data-cke-pa-onmouseover="this.src='over.png'" data-cke-saved-src="http://t/image.png" src="http://t/image.png" /></p>
Actual:
<p><img data-cke-pa-onmouseout="this.src='out.png'" data-cke-pa-onmouseover="this.src='over.png'" data-cke-saved-="" src="http://t/image.png" /></p>

basic case like this:

toHtml( '<a\n href="http://ckeditor.com">foo</a>' )

Expected:
<a data-cke-saved-href="http://ckeditor.com" href="http://ckeditor.com">foo</a>
Actual:
<a data-cke-saved-="" href="http://ckeditor.com">foo</a>

and does not fix the issue:

toHtml( '<p><a data-href="x" href="#" src-foo="y">A</a></p>' )

Expected:
<p><a data-cke-saved-href="#" data-href="x" href="#" src-foo="y">A</a></p>
Actual:
<p><a data-cke-saved-="" data-href="x" href="#" src-foo="y">A</a></p>

Thanks for the review Reinmar! Is the test branch available anywhere? I can't find an up-to-date version, nor can I get the current docs on ​CKTester to work.

[Piotrek Koszuliński]

Heh... ​http://ckeditor.com/comment/125784#comment-125784

[Oskar Schöldström]

Oh, thanks for saving me some headache hehe.

I'll come back to this once you have released your test branch, otherwise I'll just be wasting your time.

[Frederico Caldeira Knabben]

oxy's patch was almost good. Fix proposed in t/10298.

[Olek Nowodziński]

Rebased branches on latest master.

[Olek Nowodziński]

• I recommend using slice() instead of substr(): ​http://jsperf.com/substr-and-substring-and-slice.

• I found that there's one wrong, extra commit in test branch (4e06e7c96c362) that belongs to #10367.

• Pushed MT for this ticket.

[Piotrek Koszuliński]

I recommend using slice() instead of substr(): ​​http://jsperf.com/substr-and-substring-and-slice.

The performance is not an issue (it's nearly equal, isn't it?). Slice is better because it is standardised:

• ​https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/String/substr
• ​https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/String/slice

[Olek Nowodziński]

Merged fix into master, dev (​​git:8ad21b6), tests (efae6db).

[giammin]

this is not fixed!

i experience the same problem with

element.addClass('cke_blabla')
element.attributes.add('class','cke_blabla')
editor.insertHtml('<div class="cke_blabla">dfgdfg</div>')

[Jakub Ś]

Class names starting with "cke_" are classes used by CKEditor. Please treat them like reserved keyword and use other namespace e.g. "mycke_".

If you still get Problems with classes please read about ACF: ​http://ckeditor.com/blog/Upgrading-to-CKEditor-4.1
​http://ckeditor.com/blog/CKEditor-4.1-RC-Released
​http://docs.ckeditor.com/#!/guide/dev_advanced_content_filter
​http://docs.ckeditor.com/#!/api/CKEDITOR.filter-method-addTransformations
​http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-allowedContent
​http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-extraAllowedContent

[Piotrek Koszuliński]

@giammin - even if there is an issue (although, as j.swiderski explained, most likely there's not), it's not related to this specific ticket.

[giammin]

Replying to Reinmar:

@giammin - even if there is an issue (although, as j.swiderski explained, most likely there's not), it's not related to this specific ticket.

if it is not an issue (although, I think it is because in my plugin I was using the same ckeditor css naming convention and I can't) it should be mentioned in the documentation AFAIK