Opened 6 years ago

Last modified 6 years ago

#10734 confirmed Bug

icon strip generated in local builder includes all the icons

Reported by: Alfonso Martínez de Lizarrondo Owned by:
Priority: Normal Milestone:
Component: Project : CKBuilder Version:
Keywords: Cc:

Description

The icons.png generated by the local version of CKBuilder includes all the images instead of just the used icons like the online version does.

Go to http://ckeditor.com/download and download the Basic package. Now use the included build-config.js in a local version of CKEditor and use the build.sh script

Compare both icons.png files and you'll see that instead of 7Kb it's 17Kb and includes all the plugins.

Change History (3)

comment:1 Changed 6 years ago by Wiktor Walc

Did you run build.sh without any extra configuration options? I guess the answer is yes :)

Short answer to this problem:

./build.sh --skip-omitted-in-build-config

this way plugins/skins that are not included in build-config.js will not be included in a release package. (there is even a shorter version: ./build.sh -s) As a result, the strip image will contain only icons for selected plugins.


If you run ckbuilder.jar without any arguments,it will show you the list of available arguments:

java -jar ckbuilder/1.7/ckbuilder.jar


A few more words about what's going on: by default, the command line version works in a bit different way than the online version.

The online version builds CKEditor with selected plugins only. The command line version by default merges all plugins listed in build-config.js into ckeditor.js and at the same time it copies the rest of plugins (and minifies them) to the plugins folder (same with skins).

The only thing that eventually could be changed here is exactly what the title says: even when all plugins are included in a release package, plugins that are not merged into ckeditor.js should not be included in a strip image as well. This might be particularly useful now, when the hidpi icons take much more bytes.

Last edited 6 years ago by Wiktor Walc (previous) (diff)

comment:2 Changed 6 years ago by Wiktor Walc

Status: newconfirmed

comment:3 Changed 6 years ago by Alfonso Martínez de Lizarrondo

Thanks for the explanation.

In order to help other people that might not find this info, instead (or besides) using that command line switch it could be possible to specify the option to skip the extra plugins from the config file, so when people downloads a build from the online builder and uses that file in their local version they always get the same behavior.

Or maybe make this the default behavior and if anyone wants the current one, he is the one that should specify the command line parameter?

I think that most of the people would be OK with that behavior: if you have a plugin in the plugins folder, but it's not included in the build-config.js then it's not used and won't be copied to the output folder.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy