Opened 6 years ago

Last modified 6 years ago

#10737 confirmed Task

UI languages sample should show some BiDi features

Reported by: Sa'ar Zac Elias Owned by:
Priority: Normal Milestone:
Component: Documentation & Samples Version:
Keywords: Cc:

Description

Hey guys, The UI languages sample aims to show that the editor could be used in an RTL environment. While the basic goal of this sample is indeed reached (the UI does show up in Hebrew), it's worth showing some of the appropriate BiDi features CKEditor has to offer. When one changes the UI language in the sample, he might expect to try and write something using the chosen language. Currently, if the language is changed to (e.g.) Hebrew, the cursor stays on the left and the text is actually written as LTR. This could be solved either by changing the default writing direction on this sample accordingly, or at least by providing LTR/RTL and alignment buttons on the toolbar. P.S - "Try "arabic" or "hebrew" to check RTL support:" - Arabic and Hebrew should be capitalized (proper nouns). Just my two cents :)

Attachments (1)

Screen Shot 2013-08-19 at 3.44.57 PM.png (28.4 KB) - added by Sa'ar Zac Elias 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Sa'ar Zac Elias

comment:1 Changed 6 years ago by Jakub Ś

Resolution: fixed
Status: newclosed

Hi Saare,

Currently, if the language is changed to (e.g.) Hebrew, the cursor stays on the left and the text is actually written as LTR. This could be solved either by changing the default writing direction on this sample accordingly, or at least by providing LTR/RTL and alignment buttons on the toolbar.

I have just checked the UI Languages sample in CKEditor 4.2.1. When you select Hebrew rtl attribute is assigned to inner content area html element, BIDI, indent plus alignment buttons are all adjusted to RTL.
As for the langage itself, this (as you have tolde it once :) ) can only be changed in OS settings (e.g. from English to Hebrew).

IMHO this works exactly as you have described it should thus I'm closing this as fixed but if I have missed anything, please leave a comment and I will reopen this issue.

comment:2 Changed 6 years ago by Sa'ar Zac Elias

Hey Jakub,
Sorry, I should have been clearer. I meant the demo page, not the samples. I did not check the samples.
This demo has a basic toolbar, and the aforementioned features are missing.

comment:3 Changed 6 years ago by Jakub Ś

Resolution: fixed
Status: closedreopened

comment:4 Changed 6 years ago by Jakub Ś

Status: reopenedconfirmed

You are right Saare, demo page doesn't seem to work. Language is LTR and should be RTL. Samples work fine and change language to RTL while demo doesn’t.

NOTE: Perhaps for languages Full, featured editor should be used to show how language sensitive plugins react to its change.

Last edited 6 years ago by Jakub Ś (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy