Opened 12 years ago

Closed 12 years ago

#1076 closed Task (fixed)

Cell position calculation algorithm in FCKTools.GetPositionalCellIndex() and dragresizetable plugin is not accurate

Reported by: Martin Kou Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Cc:

Description

The current algorithm does not account for cells with rowSpan > 1. I should change them to using FCKTableHandler._CreateTableMap() instead.

Change History (2)

comment:1 Changed 12 years ago by Martin Kou

Here is a test case where the old position calculation algorithm fails:

<p>This is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
<p>&nbsp;</p>
<table cellspacing="1" cellpadding="1" width="200" border="1">
    <tbody>
        <tr>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
            <td rowspan="2">&nbsp;</td>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
        <tr>
            <td rowspan="2">&nbsp;</td>
            <td>&nbsp;</td>
            <td rowspan="2">&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
        <tr>
            <td rowspan="2">&nbsp;</td>
            <td>&nbsp;</td>
            <td rowspan="2">&nbsp;</td>
        </tr>
        <tr>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
        <tr>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
    </tbody>
</table>
<p>&nbsp;</p>

Using this table with the dragresizetable plugin, for example, would cause the wrong columns to be resized.

[675] and [676] have fixed the bug in the "Merge Down" command.

comment:2 Changed 12 years ago by Martin Kou

Resolution: fixed
Status: newclosed

[696] fixed the bug in the dragresizetable plugin.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy