Opened 6 years ago

Closed 6 years ago

#10828 closed Bug (fixed)

Integrate magicline with widgets

Reported by: Piotrek Koszuliński Owned by: Olek Nowodziński
Priority: Must have (possibly next milestone) Milestone: CKEditor 4.3
Component: General Version:
Keywords: Cc:

Description

  • It should ignore hidden selection container (I think, sometimes, especially on IEs, it is displayed at the top/bottom of editable when widget is focused).
  • It should not be displayed inside non-editable parts.
  • It should be correctly displayed in nested editables.
  • It should be correctly displayed between block widgets.

Attachments (1)

ie9_image2_magicline.mp4 (371.2 KB) - added by Olek Nowodziński 6 years ago.
Brokem magicline while working with image2 (IE9)

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by Olek Nowodziński

  • It should be correctly displayed between block widgets.

Also:

  • Before and after a widget (first/last child of editable).
  • Between magicline-triggering block element and widget (i.e. <div> next to block widget).

Changed 6 years ago by Olek Nowodziński

Attachment: ie9_image2_magicline.mp4 added

Brokem magicline while working with image2 (IE9)

comment:2 Changed 6 years ago by Piotrek Koszuliński

Priority: NormalHigh

comment:3 Changed 6 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:4 Changed 6 years ago by Piotrek Koszuliński

Duplicate closed: #10600.

comment:5 Changed 6 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:6 Changed 6 years ago by Olek Nowodziński

This ticket depends on #10938.

comment:7 Changed 6 years ago by Olek Nowodziński

Status: assignedreview

It's time to verify the status of integration. Branches:

comment:8 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

It's great to see a nice set of tests justifying the changes. Well done!

comment:9 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged changes into major, dev (​git:3ec2376), tests (f18fa93).

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy