Opened 6 years ago

Closed 5 years ago

#10853 closed Bug (fixed)

Image2: De-captioning unaligned image produces a widget without a paragraph wrapper

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.3.1
Component: General Version: 4.3 Beta
Keywords: Cc:

Description

  1. Open samples/plugins/image2/image2.html
  2. Start with the following code:
    <figure class="caption">
        <img alt="Saturn V" src="assets/image1.jpg" width="200" />
        <figcaption>Roll out of Saturn V on launch pad</figcaption>
    </figure>
    
  3. Double click the widget. Make sure that alignment is "none" and caption is turned off.
  4. Inspect editable's code.
    • Actual:
      <body>
          <span class="cke_widget_wrapper">
              ...
          </span>
      </body>
      
    • Expected structure:
      <body>
          <p>
              <span class="cke_widget_wrapper">
                  ...
              </span>
          </p>
      </body>
      
  5. Switching to source and back to WYSIWYG wraps the widget in P.

Change History (8)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 5 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:3 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.3CKEditor 4.3.1

comment:4 Changed 5 years ago by Olek Nowodziński

Status: assignedreview

The solution pushed to t/10853 (+extensive test coverage).

comment:5 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_failed

comment:6 in reply to:  5 Changed 5 years ago by Olek Nowodziński

Status: review_failedreview

Replying to Reinmar:

https://github.com/cksource/ckeditor-dev/commit/64adbeac3dc0378bc81231e2761eda162bec6662#diff-b76f7802eb30da69192fa23b2a6c8c71R190

You should check editor.activeEnterMode rather than editor.config.enterMode.

Nice catch. Fixed.

comment:7 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_passed

Rebased branches and pushed one additional commit to dev.

comment:8 Changed 5 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

git:73ec76c landed in master.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy