We are migrating CKEditor issue tracking to GitHub. Please, use GitHub to report any new issues.

The former tracking system (this website) will still be available in the read-only mode. All issues reported in the past will still be available publicly and can be referenced.

Important: we decided not to transfer all the tickets to GitHub, as many of them are not reproducible anymore or simply no longer requested by the community.
If the issue you are interested in, can be still reproduced in the latest version of CKEditor, feel free to report it again on GitHub.
At the same time please note that issues reported on this website are still taken into consideration when picking up candidates for next milestones.

To report a new issue, go to https://github.com/ckeditor/ckeditor-dev/issues and follow the instructions in the issue template.

Context Navigation

← Previous Change
Ticket History
Next Change →

Changes between Version 2 and Version 3 of Ticket #10864

Timestamp:: Sep 17, 2013, 9:53:50 AM (11 years ago)
Author:: Piotrek Koszuliński
Comment:: I changed my mind regarding the correct design, so I simplified this ticket.

Legend:

: Unmodified
: Added
: Removed
: Modified

Ticket #10864
- Property Summary changed from Extend widget instance only with chosen definition's properties to Set "repository" and "definition" properties in widget constructor not when registering definition

Ticket #10864 – Description

v2	v3
1		Currently we load all definition's properties to widget instance. We should only load `init` method, `name` and perhaps nothing more.
2
3		In some places code tries to access widget.dialog property and so on, but this should be changed to widget.definition.dialog.
4
5		Also, widget.repository and widget.definition should not come from definition object, but should be set in widget's constructor.
	1	Both properties are unnecessarily set in widget definition object.