Opened 11 years ago
Closed 11 years ago
#10864 closed Bug (fixed)
Set "repository" and "definition" properties in widget constructor not when registering definition
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3 |
| Component: | General | Version: | 4.3 Beta |
| Keywords: | Cc: |
Description (last modified by )
Both properties are unnecessarily set in widget definition object.
Change History (7)
comment:1 Changed 11 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 11 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 11 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | Extend widget instance only with chosen definition's properties → Set "repository" and "definition" properties in widget constructor not when registering definition |
comment:4 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
comment:6 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Rebased both branches on major and pushed a single commit to test repo.
comment:7 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on major with git:4bafac0 and tests with b88175f.
Note: See
TracTickets for help on using
tickets.
I changed my mind regarding the correct design, so I simplified this ticket.