Opened 6 years ago

Closed 5 years ago

#10864 closed Bug (fixed)

Set "repository" and "definition" properties in widget constructor not when registering definition

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.3
Component: General Version: 4.3 Beta
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

Both properties are unnecessarily set in widget definition object.

Change History (7)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:2 Changed 6 years ago by Piotrek Koszuliński

Description: modified (diff)

comment:3 Changed 6 years ago by Piotrek Koszuliński

Description: modified (diff)
Summary: Extend widget instance only with chosen definition's propertiesSet "repository" and "definition" properties in widget constructor not when registering definition

I changed my mind regarding the correct design, so I simplified this ticket.

comment:4 Changed 5 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedassigned

comment:5 Changed 5 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/10864 on dev and tests.

comment:6 Changed 5 years ago by Olek Nowodziński

Status: reviewreview_passed

Rebased both branches on major and pushed a single commit to test repo.

comment:7 Changed 5 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on major with git:4bafac0 and tests with b88175f.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy