Opened 11 years ago
Closed 11 years ago
#10863 closed Bug (fixed)
Change to which enterMode filter#applyTo defaults
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3 |
| Component: | General | Version: | 4.3 Beta |
| Keywords: | Cc: |
Description
Currently it defaults to activeEnterMode, but as we changed defaults in htmlDP to the main enterMode and filter, we should also change here.
Change History (9)
comment:1 Changed 11 years ago by
| Status: | new → confirmed |
|---|---|
| Version: | 4.2.2 (GitHub - master) → 4.3 (GitHub - major) |
comment:2 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:5 Changed 11 years ago by
| Status: | review → pending |
|---|
The proposed changes alone with the new tests are not enough to understand the reasoning behind this change. Can this be translated into a real world TC?
comment:6 Changed 11 years ago by
| Status: | pending → review |
|---|
It's the same reason as on final #9764 review. Do you remember that you asked me to change the enter mode and filter to which editor#setData & editor#getData default? I forgot to change the enter mode here, so it's just a cleanup to avoid confusion in the future
It'd be hard to find a real TC though, because most of the time filter#applyTo is used by htmlDataProcessor, which also chooses the enter mode (and it defaults to editor.enterMode, not activeEnterMode) and passes it to filter#applyTo. However, it may happen that someone will use filter#applyTo directly. Then this change may be important.
comment:7 follow-up: 8 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Ok... passing it, but it is still an unclear change for me.
comment:8 Changed 11 years ago by
Replying to fredck:
Ok... passing it, but it is still an unclear change for me.
By "unclear", I don't mean "wrong".
comment:9 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Merged to major with git:e235ac9 on dev and 8be42bf on tests.
Pushed t/10863 on dev and tests.