Opened 6 years ago

Closed 6 years ago

#10866 closed Bug (fixed)

Image2: TAB-based navigation in a dialog is broken

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.3
Component: Accessibility Version: 4.3 Beta
Keywords: Cc:

Description

When the image2 dialog is open, try navigating with TAB key. Note that it's impossible to get past "alignment" both when going forwards and backwards (SHIFT+TAB).

Change History (7)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 6 years ago by Marek Lewandowski

Owner: set to Marek Lewandowski
Status: confirmedassigned

comment:3 Changed 6 years ago by Olek Nowodziński

Owner: changed from Marek Lewandowski to Olek Nowodziński

comment:4 Changed 6 years ago by Olek Nowodziński

Created branch t/10866.

comment:5 Changed 6 years ago by Olek Nowodziński

Status: assignedreview

Here it comes:

  • Removed keyboardFocusable from CKEDITOR.ui.dialog.radio.prototype to not to break focus when reaching the radio group (focus got permanently broken once approaching the field with TAB).
  • Added keyboardFocusable to each input type="radio" of CKEDITOR.ui.dialog.radio to make them focusable.
  • Introduced role="radiogroup" along with aria-labelledby for radio inputs' container so it is correctly read by JAWS and VoiceOver (at least in Firefox).
  • Re-indented CKEDITOR.ui.dialog.radio code, post-codefix improvements, removed obsolete variable.

comment:6 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:7 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged into major in git:29ae680.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy