Opened 11 years ago
Closed 11 years ago
#10866 closed Bug (fixed)
Image2: TAB-based navigation in a dialog is broken
Reported by: | Olek Nowodziński | Owned by: | Olek Nowodziński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.3 |
Component: | Accessibility | Version: | 4.3 Beta |
Keywords: | Cc: |
Description
When the image2
dialog is open, try navigating with TAB key. Note that it's impossible to get past "alignment" both when going forwards and backwards (SHIFT+TAB).
Change History (7)
comment:1 Changed 11 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 11 years ago by
Owner: | set to Marek Lewandowski |
---|---|
Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
Owner: | changed from Marek Lewandowski to Olek Nowodziński |
---|
comment:4 Changed 11 years ago by
comment:5 Changed 11 years ago by
Status: | assigned → review |
---|
Here it comes:
- Removed
keyboardFocusable
fromCKEDITOR.ui.dialog.radio.prototype
to not to break focus when reaching the radio group (focus got permanently broken once approaching the field with TAB). - Added
keyboardFocusable
to eachinput type="radio"
ofCKEDITOR.ui.dialog.radio
to make them focusable. - Introduced
role="radiogroup"
along witharia-labelledby
for radio inputs' container so it is correctly read by JAWS and VoiceOver (at least in Firefox). - Re-indented
CKEDITOR.ui.dialog.radio
code, post-codefix improvements, removed obsolete variable.
comment:6 Changed 11 years ago by
Status: | review → review_passed |
---|
comment:7 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Merged into major in git:29ae680.
Created branch t/10866.