Opened 11 years ago
Closed 11 years ago
#10877 closed Bug (fixed)
[Blink/Webkit] WSC fails to apply changes if nested editable was focused
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3 |
| Component: | General | Version: | 4.3 Beta |
| Keywords: | Cc: |
Description
- Open image2 sample.
- Place caret in nested editable.
- Open WSC.
- Click "change to" at least once.
- Click "finish checking". Error is thrown.
Change History (8)
comment:1 Changed 11 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 11 years ago by
BTW. The stack trace of the error mentioned in the description:
contentDomUnload(WSC dialog calls setData when it is closed)editor.widgets.destroyAlleditor.setActiveFilter( null )(because nested editable is blurred)updateCommandsContext
comment:5 Changed 11 years ago by
| Summary: | WSC fails to apply changes if nested editable was focused → [Blink/Webkit] WSC fails to apply changes if nested editable was focused |
|---|
comment:6 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Rebased both branches on major. An extra commit added to tests.
comment:8 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on major with git:e49980f and 1118c18 on tests.
Note: See
TracTickets for help on using
tickets.
Pushed t/10877 on dev and tests.
I'm not 100% sure if this is the best solution, because it may mute other bugs which will cause calling the updateCommandsContext in inappropriate moments.
It'd be cool if we could assure that selection always exist, but this is A LOT MORE complicated. So I'm proposing this simple check.