Opened 11 years ago
Closed 11 years ago
#10914 closed Bug (fixed)
Plugins indentlist and indentblock missing in building config.
Reported by: | Marek Lewandowski | Owned by: | Marek Lewandowski |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.2.2 |
Component: | General | Version: | 4.2 |
Keywords: | Cc: |
Description
since: 4.2 (didn't check earlier) until master
As github user tiemevanveen points out in pull request #50:
After plugins indentlist and indentblock were introduced, we removed plugin indent from build configs in ckeditor-presets, but we have not updated config in ckeditor-dev ckeditor-dev/dev/builder/build-config.js
Expected result:
We should replace plugin indent with indentlist and indentblock
Change History (5)
comment:1 Changed 11 years ago by
Status: | new → confirmed |
---|
- Looking at full package from release version there are 3 plugins mentioned
- Looking at code: https://github.com/ckeditor/ckeditor-presets/blob/master/presets/full-build-config.js there are only 2 new plugins mentioned. But they require basic indent plugins so it is included in build.
- Looking at code in ckeditor-dev/dev/builder/build-config.js there is only indent plugin mentioned. This is IMO bad and should be changed to option with 3 or 2 plugins included. I assume that @m.lewandowski is correct and only 2 plugins should be mentioned.
comment:2 Changed 11 years ago by
Owner: | set to Marek Lewandowski |
---|---|
Status: | confirmed → review |
Fixed with git:cbd83cd974 on dev (cksource repo). Branch t/10914.
comment:3 Changed 11 years ago by
Milestone: | → CKEditor 4.2.2 |
---|
comment:4 Changed 11 years ago by
Status: | review → review_passed |
---|
comment:5 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Merged in git:b7fe2346614b