Opened 6 years ago

Closed 5 years ago

#10975 closed Bug (fixed)

[IE] Error thrown while opening color palette

Reported by: Olek Nowodziński Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.2.3
Component: UI : Floating Panel Version: 4.2.2
Keywords: Cc:

Description

What:

SCRIPT5007: Unable to get value of the property 'block': object is null or undefined

Where: colorbutton plugin's onOpen

Browser: IE9 QM

First bad commit: git:3a780a021457e7a7

This bug is a regression. Still, unless developer console is open, the bug remains invisible for the user as it doesn't break the editing.

Change History (8)

comment:1 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 4.2.2CKEditor 4.2.3

comment:2 Changed 6 years ago by Jakub Ś

Status: newconfirmed

comment:3 Changed 5 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: confirmedassigned

comment:4 Changed 5 years ago by Piotr Jasiun

Summary: [QM] Error thrown while opening color palette[IE] Error thrown while opening color palette

To reproduce this bug you have to click on color button before clicking on editable so there is no selection when you open palette.

I was able to reproduce it in IE9 and IE10 in standard mode (not only quirks).

comment:5 Changed 5 years ago by Piotr Jasiun

Status: assignedreview

The solution is to check if 'path' is not null in 'onOpen' method.

Changes in t/10975 and test in corresponding branch.

comment:6 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:7 Changed 5 years ago by Piotr Jasiun

Closed.

comment:8 Changed 5 years ago by Piotr Jasiun

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy