Opened 11 years ago
Closed 11 years ago
#10994 closed Bug (fixed)
Create Editors with jQuery sample fired from file
| Reported by: | Robert | Owned by: | Marek Lewandowski |
|---|---|---|---|
| Priority: | Low | Milestone: | CKEditor 4.2.3 |
| Component: | Documentation & Samples | Version: | |
| Keywords: | Cc: |
Description
jQuery adapter sample src attribute doesn't provide protocol part, so example opened from file gets an error:
ReferenceError: $ is not defined
Change History (10)
comment:1 Changed 11 years ago by
| Milestone: | → CKEditor 4.2.3 |
|---|---|
| Status: | new → confirmed |
comment:2 Changed 11 years ago by
Perhaps it should be simply mentioned that if you want to fire this sample from desktop you should add the protocol:)
comment:4 Changed 11 years ago by
| Owner: | set to Marek Lewandowski |
|---|---|
| Status: | confirmed → assigned |
comment:6 Changed 11 years ago by
| Status: | review → review_failed |
|---|
:/ but then if we want to run this from https, after patch we gonna have warning of mixed content... not good as well.
This should be done with document.write, probably.
comment:7 Changed 11 years ago by
This will overcomplicate things. And if someone is running samples on https I guess he knows a little bit more about what he does, than random guy downloading CKEditor package to his filesystem.
comment:8 Changed 11 years ago by
| Status: | review_failed → review_passed |
|---|
I'm sure we have more important things to discuss.
comment:10 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with git:48da8533b1 at master.
I agree that it would be good to fix this, because many developers may encounter this error. CKEditor is not supposed to fully run on
file://, but at least it should not fail so quickly.