Opened 6 years ago

Closed 6 years ago

#10994 closed Bug (fixed)

Create Editors with jQuery sample fired from file

Reported by: Robert Owned by: Marek Lewandowski
Priority: Low Milestone: CKEditor 4.2.3
Component: Documentation & Samples Version:
Keywords: Cc:

Description

jQuery adapter sample src attribute doesn't provide protocol part, so example opened from file gets an error:

ReferenceError: $ is not defined

Change History (10)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.2.3
Status: newconfirmed

I agree that it would be good to fix this, because many developers may encounter this error. CKEditor is not supposed to fully run on file://, but at least it should not fail so quickly.

comment:2 Changed 6 years ago by Jakub Ś

Perhaps it should be simply mentioned that if you want to fire this sample from desktop you should add the protocol:)

comment:3 Changed 6 years ago by Piotrek Koszuliński

It'll be much simpler if we add it ;)

comment:4 Changed 6 years ago by Marek Lewandowski

Owner: set to Marek Lewandowski
Status: confirmedassigned

comment:5 Changed 6 years ago by Marek Lewandowski

Status: assignedreview

Commited to branch t/10994.

comment:6 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

:/ but then if we want to run this from https, after patch we gonna have warning of mixed content... not good as well.

This should be done with document.write, probably.

comment:7 Changed 6 years ago by Piotrek Koszuliński

This will overcomplicate things. And if someone is running samples on https I guess he knows a little bit more about what he does, than random guy downloading CKEditor package to his filesystem.

comment:8 Changed 6 years ago by Frederico Caldeira Knabben

Status: review_failedreview_passed

I'm sure we have more important things to discuss.

comment:9 Changed 6 years ago by Piotrek Koszuliński

It was a pleasure :D Thank you.

comment:10 Changed 6 years ago by Marek Lewandowski

Resolution: fixed
Status: review_passedclosed

Fixed with git:48da8533b1 at master.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy