Opened 11 years ago
Closed 11 years ago
#11077 closed Bug (fixed)
Image2: resize records two undo snapshots
| Reported by: | Piotrek Koszuliński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3.1 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
- Open image2 sample.
- Resize image using resize handler.
- Undo once - nothing happens. Undo second time - image is resized back to its original size.
Change History (4)
comment:1 Changed 11 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | new → assigned |
comment:2 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:3 follow-up: 4 Changed 11 years ago by
| Status: | review → review_passed |
|---|
It would be a little bit safer to lock snapshot during resizing, but let's wait for a TC.
comment:4 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Replying to Reinmar:
It would be a little bit safer to lock snapshot during resizing, but let's wait for a TC.
Yip!
The fix landed in master git:9c3b8e4.
Note: See
TracTickets for help on using
tickets.
Fix: t/11077
The problem was because
saveSnapshotwas called too early onmouseup. Since DOM was modified after that (removed class, so no visual change), if any code calledsaveSnapshotagain, an additional, ghost snapshot was recorded.The fix changes the order of execution.